-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make IOPTranscript
publicly accessible
#331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tessico , LGTM, could you also fix the lint failure?
IOPTranscript
publicIOPTranscript
publicly accessible
Hmm I'm new to this action, but I can't find why CI is failing - the title seems to conform the guidelines, unless I'm missing sth? |
The reason maybe the permission setting of this PR: https://github.com/EspressoSystems/jellyfish/blob/1b03cada0ac48607fd8490a6115abc3070811757/.github/workflows/commit-title.yaml#L10C5-L10C5 Since it only checks the title, could we remove the "write" requirement here? cc @alxiong @Ancient123 |
the best action is go to "Setting" of this repo and grant write permission to this Action. which will be done by @Ancient123 (as I have communicated with him on Zulip) |
Try rebasing? If that doesn't work, I can do an administrator merge. |
if we can't figure out why the commitlint CI fails, let's just merge it first, there's no problem with the commit message of this PR @mrain |
I don't have access the settings of this repo. Could you try this and see if it proceeds? cc @alxiong @Ancient123 |
Thanks for this! |
Description
The jellyfish
IOPTranscript
has very ergonomic wrappers around merlin, why not expose it publicly.Also I added an extra convenience method for getting challenge bytes instead of field elements.
Not sure whether this is a good approach - instead one could make the
transcript
field of the struct public and allow users to call more methods directly from merlin.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer