Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ICICLE msm integration #498

Merged
merged 27 commits into from
Mar 8, 2024
Merged

feat: ICICLE msm integration #498

merged 27 commits into from
Mar 8, 2024

Commits on Feb 27, 2024

  1. nixShell setup for icicle

    @alxiong
    alxiong committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    02db3e7 View commit details
    Browse the repository at this point in the history

  2. add basic msm benchmark

    @alxiong
    alxiong committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    32835ee View commit details
    Browse the repository at this point in the history

  3. add Kzg::commit_with_gpu() and unit tests

    @alxiong
    alxiong committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ef61c72 View commit details
    Browse the repository at this point in the history

  4. update benchmark

    @alxiong
    alxiong committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    10f2d30 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. add par_iter and fix bench err

    @alxiong
    alxiong committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    250e6f4 View commit details
    Browse the repository at this point in the history

  2. finer-grain print trace, try to fix ci

    @alxiong
    alxiong committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b1f3c0c View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. split up commit_using_gpu() into 4 api

    @alxiong
    alxiong committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    514d479 View commit details
    Browse the repository at this point in the history

  2. use PCSError instead of unwrap

    @alxiong
    alxiong committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7096bad View commit details
    Browse the repository at this point in the history

  3. ci: explict all-features and avoid icicle feature

    @alxiong
    alxiong committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7ce5363 View commit details
    Browse the repository at this point in the history

  4. adjust benchmark name

    @alxiong
    alxiong committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    819eaf6 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into icicle-msm

    @alxiong
    alxiong committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    33b4d84 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. hide gpu bench behind feature flag

    @alxiong
    alxiong committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b9c9ac9 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. introduce trait GPUCommit with less mem copy during conversion

    @alxiong
    alxiong committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    4405329 View commit details
    Browse the repository at this point in the history

  2. specialize conversion and mont-based msm for bn254

    @alxiong
    alxiong committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    c43ec12 View commit details
    Browse the repository at this point in the history

  3. warmup for more accurate benchmark

    @alxiong
    alxiong committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    964c63a View commit details
    Browse the repository at this point in the history

  4. wip: add subslice into srs ref

    @alxiong
    alxiong committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    4b98d1f View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. use mem::forget() to avoid double-free panic

    @alxiong
    alxiong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    bd5dd36 View commit details
    Browse the repository at this point in the history

  2. improve test

    @alxiong
    alxiong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ca5b494 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into icicle-msm

    @alxiong
    alxiong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    4674eee View commit details
    Browse the repository at this point in the history

  4. update bench code

    @alxiong
    alxiong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    d150d66 View commit details
    Browse the repository at this point in the history

  5. test: high degree behind print-trace feature

    @alxiong
    alxiong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    34bc815 View commit details
    Browse the repository at this point in the history

  6. feat: add batch_commit for gpu

    @alxiong
    alxiong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    24083ba View commit details
    Browse the repository at this point in the history

  7. update CHANGELOG

    @alxiong
    alxiong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    49663ab View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. fix bench, add 2 handy apis, rename to gpu_commit()

    @alxiong
    alxiong committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    ae6a9ca View commit details
    Browse the repository at this point in the history

  2. nit: minor edit on profile test

    @alxiong
    alxiong committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    9fdb299 View commit details
    Browse the repository at this point in the history

  3. improve scalar type conv by 2x for batch_commit, directly use par_iter

    @alxiong
    alxiong committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    7e5862c View commit details
    Browse the repository at this point in the history

  4. fix trimmed_size logic, comparable test

    @alxiong
    alxiong committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    b371f65 View commit details
    Browse the repository at this point in the history