chore: use tag for inter-dep among member crates #639
Merged
+36
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxiong
requested review from
mrain,
ggutoski,
akonring and
philippecamacho
as code owners
mrain
approved these changes
Jul 25, 2024
|
I notice that when we tag let's be more careful next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
I encounter type compatibility error when trying to point to previously tagged
jf-plonk-v0.5.0; where I realized that we are still using relative pathpath = "../xx"for inter-depenecy among member crates, which points to the head instead of a tagged version.Since we made the decision in #556 to have independent version management/bumping among crates, we forgot to reflect that in our dependency declaration and this PR fixed that.
jf-plonk-v0.5.0and tagjf-signatures-v0.1.1to the latestmainonce this PR is merged.