-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add keccak256 merkle tree #685
Conversation
Rescue hash has a rate of 3. @sveitser I think it's better to instantiate a MT in the application since it's simple enough. If we do it here, people may think that we are enforcing some default instantiations while we are not. |
but our Sha3MT doesn't have to use rate of 3, right? also our implementation is generic of ARITY. I don't know why our Sha3Tree also choose Arity of 3
Softly disagree, the fact that our API is generic already offers flexibility. |
I just picked a random number because it was supposed to be only an example. If we are making it public we'd better make it generic to ARITY.
We could go either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think we could include this change in version 0.2.0
, and make a new tag after merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR:
impl_mt_hash_256!
for implementing boilerplate for node and digest for MT that has 32 bytes output size@mrain do you remember why we pick rate 3 for MT? is that an assumption for our current MT internals?
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.Wrote unit testsCHANGELOG.md
of touched crates.Files changed
in the GitHub PR explorer