Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Geth to v1.12 #59

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Update Geth to v1.12 #59

merged 2 commits into from
Aug 3, 2023

Conversation

jbearer
Copy link
Member

@jbearer jbearer commented Aug 3, 2023

This is the version used by the upstream, and contains a new block header field (WithdrawalsHash) which is set by Sepolia, which may be important when computing hashes of blocks returned by a Sepolia RPC.

Lockfile changes are from manually updating go-ethereum to v1.12.0 with go get, and then running go mod tidy. Code changes are based on upstream, but taken manually rather than trying to merge or cherry-pick.

This is the version used by the upstream, and contains a new
block header field (`WithdrawalsHash`) which is set by Sepolia,
which may be important when computing hashes of blocks returned by
a Sepolia RPC.

Lockfile changes are from manually updating go-ethereum to v1.12.0
with `go get`, and then running `go mod tidy`. Code changes are
based on upstream, but taken manually rather than trying to merge
or cherry-pick.
Copy link
Collaborator

@sveitser sveitser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sveitser sveitser merged commit fc12366 into hotshot-integration Aug 3, 2023
1 check passed
@sveitser sveitser deleted the update/geth branch August 3, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants