ternarys are okay, if you write them correctly

Esri · Aug 7, 2018 · 15e80a1 · 15e80a1
1 parent c4daf3c
commit 15e80a1
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/packages/arcgis-rest-auth/src/generate-token.ts b/packages/arcgis-rest-auth/src/generate-token.ts
@@ -3,6 +3,7 @@
 
 import {
   request,
+  IRequestOptions,
   IGenerateTokenParams,
   IGenerateTokenRequestOptions
 } from "@esri/arcgis-rest-request";
@@ -18,14 +19,10 @@ export function generateToken(
   requestOptionsOrParams: IGenerateTokenParams | IGenerateTokenRequestOptions
 ): Promise<IGenerateTokenResponse> {
   // TODO: remove union type and type guard next breaking change and just expect IGenerateTokenRequestOptions
-  let options: IGenerateTokenRequestOptions;
-  if ((requestOptionsOrParams as IGenerateTokenRequestOptions).params) {
-    options = requestOptionsOrParams as IGenerateTokenRequestOptions;
-  } else {
-    options = {
-      params: requestOptionsOrParams
-    };
-  }
+  const options: IRequestOptions = (requestOptionsOrParams as IGenerateTokenRequestOptions)
+    .params
+    ? (requestOptionsOrParams as IRequestOptions)
+    : { params: requestOptionsOrParams };
 
   /* istanbul ignore else */
   if (