Merge pull request #515 from Esri/refactor/common-as-dep

refactor: remove common-types entirely (and move typings into whatever package makes the most sense)

README.md

@@ -71,7 +71,6 @@ Some useful commands include:
 
 * [`@esri/arcgis-rest-request`](./packages/arcgis-rest-request/) - Underpins other packages and supports making low-level requests.
 * [`@esri/arcgis-rest-auth`](./packages/arcgis-rest-auth) - Provides methods for authenticating named users and applications.
-* [`@esri/arcgis-rest-common`](./packages/arcgis-rest-common-types) - - Stores shared methods and types used throughout the ArcGIS API.
 * [`@esri/arcgis-rest-portal`](./packages/arcgis-rest-portal) - Methods for working with ArcGIS Online/Enterprise content and users.
 * [`@esri/arcgis-rest-feature-service`](./packages/arcgis-rest-feature-service) - Functions for querying and editing features inside of hosted feature services.
 * [`@esri/arcgis-rest-feature-service-admin`](./packages/arcgis-rest-feature-service-admin) - Functions for administering hosted feature services.

packages/arcgis-rest-auth/package.json

@@ -16,11 +16,9 @@
     "tslib": "^1.9.3"
   },
   "devDependencies": {
-    "@esri/arcgis-rest-common": "^1.19.2",
     "@esri/arcgis-rest-request": "^1.19.2"
   },
   "peerDependencies": {
-    "@esri/arcgis-rest-common": "^1.19.2",
     "@esri/arcgis-rest-request": "^1.19.2"
   },
   "scripts": {

packages/arcgis-rest-auth/src/UserSession.ts

@@ -19,11 +19,12 @@ import {
   ArcGISAuthError,
   IAuthenticationManager,
   ITokenRequestOptions,
-  cleanUrl
+  cleanUrl,
+  IUser
 } from "@esri/arcgis-rest-request";
+
 import { generateToken } from "./generate-token";
 import { fetchToken, IFetchTokenResponse } from "./fetch-token";
-import { IUser } from "@esri/arcgis-rest-common";
 
 /**
  * Internal utility for resolving a Promise from outside its constructor.

packages/arcgis-rest-auth/src/index.ts

@@ -6,4 +6,3 @@ export * from "./UserSession";
 export * from "./fetch-token";
 export * from "./generate-token";
 export * from "./authenticated-request-options";
-export * from "./get-user-url";

packages/arcgis-rest-auth/test/UserSession.test.ts

@@ -9,7 +9,7 @@ import {
   ArcGISRequestError,
   ArcGISAuthError,
   ErrorTypes
-} from "@esri/arcgis-rest-request";
+} from "@esri/arcgis-rest-request/src";
 import * as fetchMock from "fetch-mock";
 import { YESTERDAY, TOMORROW } from "./utils";