Skip to content

Commit

Permalink
refactor: deprecate common-types package (in favor of common)
Browse files Browse the repository at this point in the history
AFFECTS PACKAGES:
@esri/arcgis-rest-auth
@esri/arcgis-rest-common
@esri/arcgis-rest-feature-service-admin
@esri/arcgis-rest-feature-service
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-groups
@esri/arcgis-rest-items
@esri/arcgis-rest-sharing
@esri/arcgis-rest-users
batch-geocoder

BREAKING CHANGE:
deprecate common-types package (in favor of common)
  • Loading branch information
jgravois committed Apr 11, 2019
1 parent ded66d3 commit 6ab2e75
Show file tree
Hide file tree
Showing 62 changed files with 523 additions and 720 deletions.
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ Some useful commands include:

* [`@esri/arcgis-rest-request`](./packages/arcgis-rest-request/) - Underpins other packages and supports making low-level requests.
* [`@esri/arcgis-rest-auth`](./packages/arcgis-rest-auth) - Provides methods for authenticating named users and applications.
* [`@esri/arcgis-rest-common-types`](./packages/arcgis-rest-common-types) - Stores objects common across the ArcGIS API.
* [`@esri/arcgis-rest-common`](./packages/arcgis-rest-common-types) - - Stores shared methods and types used throughout the ArcGIS API.
* [`@esri/arcgis-rest-items`](./packages/arcgis-rest-items) - Methods for working with ArcGIS Online/Enterprise content.
* [`@esri/arcgis-rest-groups`](./packages/arcgis-rest-groups) - Methods for working with ArcGIS Online/Enterprise groups.
* [`@esri/arcgis-rest-users`](./packages/arcgis-rest-users) - Methods for working with ArcGIS Online/Enterprise users.
Expand All @@ -80,8 +80,6 @@ Some useful commands include:
* [`@esri/arcgis-rest-geocoder`](./packages/arcgis-rest-geocoder) - Geocoding wrapper for `@esri/arcgis-rest-js`
* [`@esri/arcgis-rest-feature-service-admin`](./packages/arcgis-rest-feature-service-admin) - Functions for creating and updating feature services.
* [`@esri/arcgis-rest-routing`](./packages/arcgis-rest-routing) - Routing and directions wrapper for `@esri/arcgis-rest-js`.
* [`@esri/arcgis-rest-common`](./packages/arcgis-rest-common) - Stores shared methods and types used throughout the ArcGIS API.


### Frequently Asked Questions

Expand Down
2 changes: 1 addition & 1 deletion demos/batch-geocoder-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"homepage": "https://github.com/Esri/arcgis-rest-js#readme",
"dependencies": {
"@esri/arcgis-rest-auth": "^1.19.2",
"@esri/arcgis-rest-common-types": "^1.19.2",
"@esri/arcgis-rest-common": "^1.19.2",
"@esri/arcgis-rest-geocoder": "^1.19.2",
"@esri/arcgis-rest-request": "^1.19.2",
"isomorphic-fetch": "^2.2.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/arcgis-rest-auth/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@
"tslib": "^1.9.3"
},
"devDependencies": {
"@esri/arcgis-rest-common-types": "^1.19.2",
"@esri/arcgis-rest-common": "^1.19.2",
"@esri/arcgis-rest-request": "^1.19.2"
},
"peerDependencies": {
"@esri/arcgis-rest-common-types": "^1.19.2",
"@esri/arcgis-rest-common": "^1.19.2",
"@esri/arcgis-rest-request": "^1.19.2"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/arcgis-rest-auth/src/UserSession.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
} from "@esri/arcgis-rest-request";
import { generateToken } from "./generate-token";
import { fetchToken, IFetchTokenResponse } from "./fetch-token";
import { IUser } from "@esri/arcgis-rest-common-types";
import { IUser } from "@esri/arcgis-rest-common";

/**
* Internal utility for resolving a Promise from outside its constructor.
Expand Down
66 changes: 0 additions & 66 deletions packages/arcgis-rest-common-types/README.md

This file was deleted.

48 changes: 0 additions & 48 deletions packages/arcgis-rest-common-types/package.json

This file was deleted.

Loading

0 comments on commit 6ab2e75

Please sign in to comment.