Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create example which demonstrates how to batch geocode a .csv #97

Closed
jgravois opened this issue Dec 29, 2017 · 12 comments
Closed

create example which demonstrates how to batch geocode a .csv #97

jgravois opened this issue Dec 29, 2017 · 12 comments
Assignees

Comments

@jgravois
Copy link
Contributor

ref: Esri/geoservices-js#95

@jgravois jgravois self-assigned this Dec 29, 2017
@mpayson
Copy link
Contributor

mpayson commented Dec 30, 2017

@jgravois I'm happy to build the sample too if it'd be helpful, been eager to try this lib out

@jgravois
Copy link
Contributor Author

that'd be great!

@phpmaps
Copy link

phpmaps commented Jan 4, 2018

@jgravois @mpayson @patrickarlt so what is the minimum node.js version required to run this project? on the project home page there is an example that uses what looks to be the promise / then() pattern, which suggests v6x. can the sample be v8x with (async / await)?

@jgravois
Copy link
Contributor Author

jgravois commented Jan 4, 2018

check out the Node.js getting started section in https://esri.github.io/arcgis-rest-js/guides/

the gist is that even in Node.js v8 you need to import isomorphic-fetch and isomorphic-form-data to polyfill yourself.

@mpayson
Copy link
Contributor

mpayson commented Jan 4, 2018

two quick questions:

  1. is the scope to create a sample in the browser for users to upload a csv and download the results, or just create a node script that writes back the output? I'm in favor of the latter since it's slightly more straight forward and could be pulled into html
  2. any recommended approaches for parsing csv strings? I'm leaning towards Papa Parse

thanks!

@jgravois
Copy link
Contributor Author

jgravois commented Jan 4, 2018

@mpayson just follow your ❤️ and you'll go far 😄

@phpmaps
Copy link

phpmaps commented Jan 4, 2018

@mpayson I would say the latter, too b/ it has simple and real value. Though for me arcgis-rest-js is a new project that I've not explored. If it already includes consistency in samples that show end-to-end browser to JS backend, I vote for consistency. Never a fan of wearing a tie to a Hawaiian shirt party. On parsers @jgravois and I had already started something with cvs-parser in the developer support repo https://github.com/Esri/developer-support/tree/master/web-js/batch-geocoding-nodejs.

@phpmaps
Copy link

phpmaps commented Jan 4, 2018

@mpayson per comment above follow your heart. I'd like to get something done here in a joint effort that leverages the polyfill part also mentioned above. That obviously coupled with the issue GIS and batch geocoding.

@mpayson
Copy link
Contributor

mpayson commented Jan 12, 2018

fyi @phpmaps started to work on this here. holler with thoughts/feedback!

still need to:

  • write results back to csv
  • annotate
  • (maybe) condense duplicate requests to save credits

@jgravois
Copy link
Contributor Author

cool! open up a PR whenever you're ready and i can take a deeper look.

@phpmaps
Copy link

phpmaps commented Jan 12, 2018

@mpayson way to go on this! I started reviewing good use of config file. I like how it's not just a JSON doc. I am with @jgravois, a PR would be great. The only thing I might say to update would be the last few lines, where it seems like there may be an unnecessary then() right before the catch. I might consider putting the console log bit directly inside where promise.all resolves.

@mpayson
Copy link
Contributor

mpayson commented Jan 24, 2018

updated and first pr, would love to hear your feedback!

#105

jgravois added a commit to mpayson/arcgis-rest-js that referenced this issue Feb 22, 2018
…v in node

AFFECTS PACKAGES:
batch-geocoder
@esri/arcgis-rest-geocoder-vanilla
@esri/arcgis-rest-demo-vanilla

ISSUES CLOSED: Esri#97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants