-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create example which demonstrates how to batch geocode a .csv #97
Comments
@jgravois I'm happy to build the sample too if it'd be helpful, been eager to try this lib out |
that'd be great! |
@jgravois @mpayson @patrickarlt so what is the minimum node.js version required to run this project? on the project home page there is an example that uses what looks to be the promise / then() pattern, which suggests v6x. can the sample be v8x with (async / await)? |
check out the Node.js getting started section in https://esri.github.io/arcgis-rest-js/guides/ the gist is that even in Node.js |
two quick questions:
thanks! |
@mpayson just follow your ❤️ and you'll go far 😄 |
@mpayson I would say the latter, too b/ it has simple and real value. Though for me arcgis-rest-js is a new project that I've not explored. If it already includes consistency in samples that show end-to-end browser to JS backend, I vote for consistency. Never a fan of wearing a tie to a Hawaiian shirt party. On parsers @jgravois and I had already started something with cvs-parser in the developer support repo https://github.com/Esri/developer-support/tree/master/web-js/batch-geocoding-nodejs. |
@mpayson per comment above follow your heart. I'd like to get something done here in a joint effort that leverages the polyfill part also mentioned above. That obviously coupled with the issue GIS and batch geocoding. |
cool! open up a PR whenever you're ready and i can take a deeper look. |
@mpayson way to go on this! I started reviewing good use of config file. I like how it's not just a JSON doc. I am with @jgravois, a PR would be great. The only thing I might say to update would be the last few lines, where it seems like there may be an unnecessary then() right before the catch. I might consider putting the console log bit directly inside where promise.all resolves. |
updated and first pr, would love to hear your feedback! |
…v in node AFFECTS PACKAGES: batch-geocoder @esri/arcgis-rest-geocoder-vanilla @esri/arcgis-rest-demo-vanilla ISSUES CLOSED: Esri#97
ref: Esri/geoservices-js#95
The text was updated successfully, but these errors were encountered: