Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw ArcGISAuthError instead of Error when unable to refresh a token #111

Merged
merged 1 commit into from
Feb 1, 2018
Merged

throw ArcGISAuthError instead of Error when unable to refresh a token #111

merged 1 commit into from
Feb 1, 2018

Conversation

patrickarlt
Copy link
Contributor

Fix #56

@patrickarlt
fix(UserSession): throw ArcGISAuthError instead of Error when unable …
8854765 
…to refresh a token

AFFECTS PACKAGES:
@esri/arcgis-rest-auth

ISSUES CLOSED: #56
@coveralls
Copy link

coveralls commented Feb 1, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 8854765 on fix-56 into f12822c on master.

noahmulfinger
noahmulfinger approved these changes Feb 1, 2018
View reviewed changes
Copy link
Contributor

@noahmulfinger noahmulfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrickarlt patrickarlt merged commit d1a59fc into master Feb 1, 2018
@jgravois jgravois deleted the fix-56 branch February 1, 2018 17:38
@jgravois
Copy link
Contributor

jgravois commented Feb 1, 2018

and it even had the correct number of @coveralls replies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahmulfinger noahmulfinger noahmulfinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickarlt @coveralls @jgravois @noahmulfinger