feat(:unlock:): add support for an OAuth flow that triggers social me… #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dia login automatically AFFECTS PACKAGES: @esri/arcgis-rest-auth ISSUES CLOSED: #239
tomwayson
approved these changes
Jul 10, 2018
| @@ -156,6 +163,11 @@ export interface IUserSessionOptions { | |||
| */ | |||
| portal?: string; | |||
|
|
|||
| /** | |||
| * The authentication provider to use. Defaults to ArcGIS, but Google and Facebook social media logins can also be used. | |||
There was a problem hiding this comment.
we may want to say something here like: "Specifying a non-ArcGIS provider will take the user directly to that provider's OAuth page."
| redirectUri | ||
| )}&state=${state}&locale=${locale}`; | ||
| } else { | ||
| url = `${portal}/oauth2/social/authorize?client_id=${clientId}&socialLoginProviderName=${provider}&autoAccountCreateForSocial=true&response_type=token&expiration=${duration}&redirect_uri=${encodeURIComponent( |
There was a problem hiding this comment.
This works for Hub, so you can ignore #239 (comment) - we can add an option for this later if others don't want this behavior.
There was a problem hiding this comment.
now I'm leaning back the other way: #239 (comment)
There was a problem hiding this comment.
My comments #239 (comment)
|
LGTM |
!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dia login automatically
AFFECTS PACKAGES:
@esri/arcgis-rest-auth
ISSUES CLOSED: #239