Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: access is required when creating a new group #380

Merged
merged 3 commits into from
Nov 2, 2018
Merged

fix: access is required when creating a new group #380

merged 3 commits into from
Nov 2, 2018

Conversation

jgravois
Copy link
Contributor

@jgravois jgravois commented Nov 2, 2018

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6e6f7a6 on fix/group-access into 55a6dca on master.

@Esri Esri deleted a comment from coveralls Nov 2, 2018
@Esri Esri deleted a comment from coveralls Nov 2, 2018
@Esri Esri deleted a comment from coveralls Nov 2, 2018
pranavkulkarni
pranavkulkarni approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@pranavkulkarni pranavkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @jgravois

@jgravois
fix(:bug:): tags arent required to create a group
72ffd35 
AFFECTS PACKAGES:
@esri/arcgis-rest-groups
@esri/arcgis-rest-items
@jgravois jgravois merged commit 029e648 into master Nov 2, 2018
@jgravois jgravois deleted the fix/group-access branch November 2, 2018 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkulkarni pranavkulkarni pranavkulkarni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgravois @coveralls @pranavkulkarni