Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add utility method to trim whitespace and trailing slashes from input urls #400

Merged
merged 1 commit into from
Nov 26, 2018
Merged

add utility method to trim whitespace and trailing slashes from input urls #400

merged 1 commit into from
Nov 26, 2018

Conversation

jgravois
Copy link
Contributor

halfway toward resolving #398

AFFECTS PACKAGES:
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-request

@jgravois
fix(:bathtub:): add utility method to trim whitespace and trailing sl…
8f86578 
…ashes from input urls

AFFECTS PACKAGES:
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-request
@jgravois jgravois requested a review from tomwayson November 26, 2018 20:52
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8f86578 on feat/trim into d228c86 on master.

tomwayson
tomwayson approved these changes Nov 26, 2018
View reviewed changes
Copy link
Member

@tomwayson tomwayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomwayson
Copy link
Member

Obviously there are many other places we could/should use cleanUrl() when appending to the URL besides the places you've taken care of in this PR. Is your idea that we do the others over time, i.e. on a package by package basis and split up the work?

@jgravois
Copy link
Contributor Author

Obviously there are many other places we could/should use cleanUrl() when appending to the URL

this PR actually covers the majority (items, users, groups, sharing, feature-service-admin) because the method is called internally by getPortalUrl().

that said, for sure there are still holdouts that we can/should get to in time.

@jgravois jgravois merged commit 834f242 into master Nov 26, 2018
@jgravois jgravois deleted the feat/trim branch November 26, 2018 22:00
@tomwayson tomwayson mentioned this pull request Nov 27, 2018
Closed
@jgravois jgravois mentioned this pull request Apr 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomwayson tomwayson tomwayson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgravois @coveralls @tomwayson