-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-export IGeocodeParams (until v2.0.0) #468
Conversation
if @tomwayson (or any other SemVer police) tell me i need to bump to |
@jgravois why not just add it back in until 2.0.0 THEN remove it? |
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 94 94
Lines 1209 1209
Branches 219 219
=====================================
Hits 1209 1209
Continue to review full report at Codecov.
|
You monster 👹 👿 ! |
that never even occurred to me. great idea! |
@jgravois should we really remove this anyway?? leaving it in doesn't bump out bundle sizes and leaving it in also allow TypeScript users to get autocomplete and stricter type checking in their IDEs. |
it should absolutely be removed. its an abandoned antipattern. as you said in #137 (comment), we want folks to extend |
Derp good point. |
@skitterm aptly pointed out that i removed
IGeocodeParams
inv1.17.0
.fb2ba9a#diff-094efe5f622403522c0543b08434e397
just because we weren't actually utilizing the interface in any of the geocoding methods doesn't mean other developers weren't using it.
whoops!
this PR just adds a note to the CHANGELOG as breadcrumb. while i was in there i bumped the copyright year and added keywords to our package.json files to fix this 😢