fix: dont stringify values in item calls #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFFECTS PACKAGES: @esri/arcgis-rest-items add tests simpler more
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 95 95
Lines 1214 1214
Branches 225 225
=====================================
Hits 1214 1214
Continue to review full report at Codecov.
|
tomwayson
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR can be considered an amendment to #475.
there's no need for item methods to stringify parameters,
request()handles this internally.AFFECTS PACKAGES:
@esri/arcgis-rest-items