Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated crud params for v2 #510

Merged
merged 1 commit into from
Apr 11, 2019
Merged

remove deprecated crud params for v2 #510

merged 1 commit into from
Apr 11, 2019

Conversation

COV-GIS
Copy link
Contributor

@COV-GIS COV-GIS commented Apr 11, 2019

Copy link
Contributor

@jgravois jgravois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @COV-GIS! i'll be glad to stop seeing those warnings in the test suite.

i've created a new v2.0.0 branch. can you update this PR to use it as the base instead of master please?

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #510 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #510   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          95     95           
  Lines        1221   1209   -12     
  Branches      227    224    -3     
=====================================
- Hits         1221   1209   -12
Impacted Files Coverage Δ
packages/arcgis-rest-feature-service/src/update.ts 100% <ø> (ø) ⬆️
packages/arcgis-rest-feature-service/src/delete.ts 100% <ø> (ø) ⬆️
packages/arcgis-rest-feature-service/src/add.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1db78b7...ce44303. Read the comment docs.

@COV-GIS COV-GIS changed the base branch from master to v2.0.0 April 11, 2019 18:49
@COV-GIS
Copy link
Contributor Author

COV-GIS commented Apr 11, 2019

I've never changed the base before. If it causes problems let me know and I'll pull v2.0.0 down and branch it for a new PR.

@jgravois jgravois changed the title remove depreciated crud params for v2 remove deprecated crud params for v2 Apr 11, 2019
@jgravois jgravois merged commit b6041f2 into Esri:v2.0.0 Apr 11, 2019
@COV-GIS COV-GIS deleted the remove-depreciated-crud-params branch April 11, 2019 18:59
@COV-GIS
Copy link
Contributor Author

COV-GIS commented Apr 12, 2019

thanks for the homonym fix @jgravois. it didn't look right but ran with it and did the ol' copy and paste routine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants