Refactor feature-layer/ I*Params to I*Options

[tomwayson]

more consistent naming for interfaces in the feature-layer package

AFFECTS PACKAGES:
@esri/arcgis-rest-feature-layer

BREAKING CHANGE:
renamed IEditFeaturesParams to ISharedEditOptions & ISharedQueryParams to ISharedQueryOptions;
removed IDeleteFeaturesParams

[tomwayson]

addresses #520 (review)

[tomwayson]

while doing this I noticed that IDeleteFeaturesResult is inconsistent w/ the other I*Response interfaces

but I assume we're going to get rid of of all of those as per #137, so I didn't address that in this PR.

Speaking of, do you want me to do ^^^ for the feature-layer package, @jgravois? I assume it would be a matter of just removing the interface and inlining the shape of the response into the function declaration's Promise<>, like:

export function deleteFeatures(
  requestOptions: IDeleteFeaturesRequestOptions
): Promise<{ deleteResults?: IEditFeatureResult[]; }> {
// instead of Promise<IDeleteFeaturesResult>

right?

[jgravois]

right?

right.

[COV-GIS]

@jgravois @tomwayson the reason add, update and delete had different result interfaces is ags returns different for each. i haven't been following the rework closely so maybe it doesn't matter. but if there is going to be some sort of shared result interface just be aware the result is different.

[tomwayson]

but if there is going to be some sort of shared result interface just be aware the result is different.

No shared interface, just each fn will declare inline what it returns.

[COV-GIS]

Good deal.

On hold starting a couple new projects to get up to speed on v2. I appreciate all the debate and hard work for my benefit @tomwayson @jgravois @patrickarlt. :)

[tomwayson]

sounds like we've got our first beta tester!

[tomwayson]

response interfaces removed in #523

[jgravois]

i'm loathe to point this out, but my OCD rules everything around me.

historically we've used IWhateverRequestOptions. I actually prefer ISharedQueryOptions over ISharedQueryRequestOptions though. The length of the interface names I wrote has always annoyed me.

that said, i don't think dropping Request from all the other interfaces isn't worth the PITA it would entail either.

All this to say, whatever you decide to do here, i'm behind you 100%.

[jgravois]

i was thinking this:

export interface ISharedQueryOptions extends ILayerRequestOptions {

so that you could do

export interface IAddFeaturesRequestOptions
  extends ISharedEditOptions {

[tomwayson]

Yeah, I'd love to pull "Request" from all the options. I don't think the work would be bad, it would just be the fact that we would be moving all the 🧀 , which shouldn't affect too many users. I would guess that even TS users pass POJOs to the fns most of the time.

[jgravois]

I'd love to pull "Request" from all the options.

its a wonder how either of us gets any real work done.

[tomwayson]

I don't think that we do.

[patrickarlt]

@jgravois I'm going to make a sticker of this:

my OCD rules everything around me.