Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types package #524

Merged
merged 4 commits into from
Apr 18, 2019
Merged

Types package #524

merged 4 commits into from
Apr 18, 2019

Conversation

patrickarlt
Copy link
Contributor

The PR moves all common shared types back into a -types package. All non request packages now depend on the -types package and re-export types that they use from -types. Typedoc does not put reexported items under their exporting package but rather under the package where the source is defined. To resolve this each type now notes any additional packages it can be imported from.

#137 (comment)

@patrickarlt patrickarlt changed the base branch from master to v2.0.0 April 18, 2019 15:45
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (v2.0.0@ec366de). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             v2.0.0   #524   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     95           
  Lines             ?   1354           
  Branches          ?    239           
=======================================
  Hits              ?   1354           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
packages/arcgis-rest-auth/src/UserSession.ts 100% <ø> (ø)
...es/arcgis-rest-feature-layer/test/mocks/service.ts 100% <ø> (ø)
packages/arcgis-rest-auth/src/index.ts 100% <ø> (ø)
packages/arcgis-rest-portal/src/index.ts 100% <ø> (ø)
.../arcgis-rest-portal/test/mocks/groups/responses.ts 100% <ø> (ø)
packages/arcgis-rest-geocoding/src/geocode.ts 100% <ø> (ø)
...ages/arcgis-rest-portal/src/util/generic-search.ts 100% <ø> (ø)
packages/arcgis-rest-request/src/index.ts 100% <ø> (ø)
packages/arcgis-rest-feature-layer/src/index.ts 100% <ø> (ø)
...ages/arcgis-rest-feature-layer/src/queryRelated.ts 100% <ø> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec366de...f24a433. Read the comment docs.

Copy link
Contributor

@jgravois jgravois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i:

  • synced with v2.0.0 to resolve a merge conflict
  • fixed a few typos
  • esriUnits > Units
  • esriFieldType > FieldType

this is g2g.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants