Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have travis target headless firefox too #95

Merged
merged 2 commits into from
Dec 28, 2017
Merged

have travis target headless firefox too #95

merged 2 commits into from
Dec 28, 2017

Conversation

jgravois
Copy link
Contributor

resolves #19

including coveralls as a reporter in the karma.conf was redundant.

@jgravois jgravois requested a review from patrickarlt December 28, 2017 18:44
patrickarlt
patrickarlt requested changes Dec 28, 2017
View reviewed changes
Copy link
Contributor

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgravois we should see a coveralls check/comment here too right?

@jgravois
Copy link
Contributor Author

we should see a coveralls check/comment here too right?

yup. just pushed up another commit now that should fix that.

@coveralls
Copy link

coveralls commented Dec 28, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 7b1d163 on firefox into 46fc03c on master.

@patrickarlt patrickarlt merged commit 28a3cca into master Dec 28, 2017
@jgravois jgravois deleted the firefox branch December 28, 2017 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickarlt patrickarlt patrickarlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup headless Chrome and Firefox tests on Travis
3 participants
@jgravois @coveralls @patrickarlt