Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[input-date-picker] faulty element visibility assertion #10490

Closed
maxpatiiuk opened this issue Oct 5, 2024 · 4 comments
Closed

[input-date-picker] faulty element visibility assertion #10490

maxpatiiuk opened this issue Oct 5, 2024 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.

Comments

@maxpatiiuk
Copy link
Member

Priority impact

p - low

Test type

incomplete test

Which Component(s)

input-date-picker

Unstable Tests

The following input-date-picker test is supposevely checking whether the date-picker calendar wrapper is open:

calcite-design-system/packages/calcite-components/src/components/input-date-picker/input-date-picker.e2e.ts

Lines 162 to 168 in 42c1329

const wrapper = await page.waitForFunction(
(calendarWrapperClass: string) =>
document.querySelector("calcite-input-date-picker").shadowRoot.querySelector(`.${calendarWrapperClass}`),
{},
CSS.calendarWrapper,
);
expect(await wrapper.isIntersectingViewport()).toBe(true);

However, it appears that this test condition is passing even if the date-picker wrapper is not open. (e.g if I move this assertion to be before await input.click();, it still passes).

TODO:

  • Improve this assertion (or add this.open check)?
  • Evaluate other places that may be similarly effected

Test error, if applicable

No response

PR skipped, if applicable

No response

Additional Info

No response
@maxpatiiuk maxpatiiuk added testing Issues related to automated or manual testing. 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Oct 5, 2024
@github-actions github-actions bot added the p - low Issue is non core or affecting less that 10% of people using the library label Oct 5, 2024
@jcfranco
Copy link
Member

jcfranco commented Oct 9, 2024

This might get resolved by #8402. cc @anveshmekala

@jcfranco jcfranco added the blocked This issue is blocked by another issue. label Oct 9, 2024
anveshmekala added a commit that referenced this issue Oct 9, 2024
@anveshmekala
fix #10490
682ec6f
@anveshmekala anveshmekala self-assigned this Oct 9, 2024
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Oct 9, 2024
@jcfranco jcfranco mentioned this issue Oct 9, 2024
Closed
@anveshmekala anveshmekala mentioned this issue Oct 11, 2024
Merged
anveshmekala added a commit that referenced this issue Oct 23, 2024
@anveshmekala
feat(input-date-picker, date-picker): improve date picking experience (…
24d43ad 
…#8402)

**Related Issue:** #3455, #10113 

## Summary

Update `calcite-date-picker` & `calcite-input-date-picker` UI & UX.



![4D1CFC3C-8FF9-4493-9178-4DEDA0417031](https://github.com/user-attachments/assets/4b1f5a12-85df-4577-b1cd-812c22e41ef7)

### Key changes
- display two calendars for range irrespective of layout.
- No longer switches focus from day to end input when startDate is
selected initially.
- Month selection is possible via select menu
- No longer positions the date-picker component relative to endInput
when endInput is focused in range.
- Dates from previous months are not visible in range calendar.
- Divider indicator icons are removed in horizontal layout for range in
input-date-picker.
- No longer uses chevron icon which indicate the open status of
input-date-picker in startInput field.


Other issues resolved :
#6321
#6410
#10301
#10291
#10113
#10243
#10490

Blocked issues: #9167 

Wiki
https://github.com/Esri/calcite-design-system/wiki/date%E2%80%90picker-enhancement-%238402
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 23, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned anveshmekala Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions GitHub Actions
Copy link
Contributor

Issue #3455 has been closed, this issue is ready for re-evaluation.

cc @geospatialem,@DitwanP

@github-actions github-actions bot removed the blocked This issue is blocked by another issue. label Oct 25, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Oct 29, 2024 •
edited
Loading

No longer an issue. Test was updated to resolve this

@DitwanP DitwanP closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2024
@DitwanP DitwanP removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jcfranco @geospatialem @maxpatiiuk @DitwanP @anveshmekala