Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action appearance="clear" hover state should follow general pattern #3834

Closed
2 tasks
asangma opened this issue Jan 1, 2022 · 7 comments
Closed
2 tasks

Action appearance="clear" hover state should follow general pattern #3834

asangma opened this issue Jan 1, 2022 · 7 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. low risk Issues with low risk for consideration in low risk milestones p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation.
Milestone
2023 November Pri...

Comments

@asangma
Copy link
Contributor

asangma commented Jan 1, 2022

Actual Behavior

When Action has appearance="clear", its hover state is kind of a border.

Expected Behavior

It should probably be a solid background color and follow the same pattern that Button uses and utilize --calcite-button-transparent-hover.

Yes, that's what Button uses for appearance="transprent", but that's a different discussion.

Reproduction Steps and Sample

Sample: https://codepen.io/mtb-alan/pen/abLYBNr

  1. Hover over the Action.

Relevant Info

Reproducible version: @esri/calcite-components@1.0.0-<version>

  • CDN
  • NPM package

Regression? Last working version: @esri/calcite-components@1.0.0-<version>
@asangma asangma added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 1, 2022
@macandcheese
Copy link
Contributor

@asangma are any other changes to existing components needed to make this consistent across the library?

@macandcheese macandcheese added enhancement Issues tied to a new feature or request. and removed bug Bug reports for broken functionality. Issues should include a reproduction of the bug. labels Feb 10, 2022
@macandcheese
Copy link
Contributor

@asangma - I'm going to move this to an enhancement request. There are other components that use the clear prop name so we should audit these consistently if we decide to make a change.

@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Jun 29, 2022
@macandcheese
Copy link
Contributor

@ashetland @SkyeSeitz can we take a look at this now that the nomenclature has changed and see what's needed here?

@ashetland
Copy link

ashetland commented Dec 19, 2022 •
edited
Loading

Agree. The appearance=transparent of Action should follow the same hover pattern as Button. Is this another audit situation of hover states on transparent appearance?

@geospatialem geospatialem added ready for dev Issues ready for development implementation. p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed design Issues that need design consultation prior to development. needs triage Planning workflow - pending design/dev review. labels Apr 17, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label May 1, 2023
@geospatialem geospatialem added this to the 2023 August Priorities milestone May 1, 2023
@ashetland
Copy link

Figma file for reference.

@brittneytewks brittneytewks added the low risk Issues with low risk for consideration in low risk milestones label Aug 30, 2023
@macandcheese macandcheese self-assigned this Nov 15, 2023
@macandcheese macandcheese mentioned this issue Nov 17, 2023
Merged
@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Nov 20, 2023
macandcheese added a commit that referenced this issue Nov 20, 2023
@macandcheese
fix(action): Update transparent action styles (#8194)
0f12489 
**Related Issue:** #3834 

## Summary
cc @asangma @SkyeSeitz @ashetland
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 20, 2023
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned macandcheese Nov 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 20, 2023
@geospatialem
Copy link
Member

Verified in the main branch.
verify-transparency-action-hover-state

benelan pushed a commit that referenced this issue Nov 24, 2023
@macandcheese @benelan
fix(action): Update transparent action styles (#8194)
6aadef8 
**Related Issue:** #3834 

## Summary
cc @asangma @SkyeSeitz @ashetland
benelan pushed a commit that referenced this issue Nov 24, 2023
@macandcheese @benelan
fix(action): Update transparent action styles (#8194)
d4b14d6 
**Related Issue:** #3834 

## Summary
cc @asangma @SkyeSeitz @ashetland
benelan pushed a commit that referenced this issue Nov 26, 2023
@macandcheese @benelan
fix(action): Update transparent action styles (#8194)
7d2b61a 
**Related Issue:** #3834 

## Summary
cc @asangma @SkyeSeitz @ashetland
@brittneytewks brittneytewks added the design Issues that need design consultation prior to development. label Dec 11, 2023
@ashetland ashetland mentioned this issue Dec 28, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. low risk Issues with low risk for consideration in low risk milestones p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2023 November Priorities
Development

No branches or pull requests
7 participants
@alisonailea @macandcheese @geospatialem @asangma @DitwanP @ashetland @brittneytewks