Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List] Change multiple icon or Add prop to support multiple icon types #6603

Closed
geospatialem opened this issue Mar 14, 2023 · 2 comments
Closed
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone

Comments

@geospatialem
Copy link
Member

Description

Before replacing the deprecated pick-list with the list, the selectionAppearance icon defaulted to a simple check.

For consistency with the previous structure of pick-list, we could either:

  1. Change the multiple icon to be in line with the pick-list and add the "check" icon, or

  2. Allow users select from a few differing options. Could be similar to the accordion's iconType prop.

pick-list (current and expected in list):

image

list (current):

image

Acceptance Criteria

Support the "check" icon when the list's selectionAppearance is set to and selectionMode is set to multiple.

Expected:

image

Relevant Info

Came up in a Community discussion on 3/14/23.

Which Component

list and list-item

Example Use Case

For testing/current use case: https://codepen.io/geospatialem/pen/WNgzByM

image

Esri team

Calcite (design)

@geospatialem geospatialem added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. design Issues that need design consultation prior to development. labels Mar 14, 2023
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label Mar 14, 2023
@geospatialem
Copy link
Member Author

Consider with #6700

@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jun 15, 2023
@brittneytewks brittneytewks added this to the Design Sprint Next milestone Jun 15, 2023
@ashetland ashetland self-assigned this Aug 7, 2023
@ashetland ashetland added p - medium Issue is non core or affecting less that 60% of people using the library 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Aug 7, 2023
@ashetland
Copy link

Closing in favor of #6700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

3 participants