-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have a clearer unselected state in Calcite List #6700
Comments
I would adjust the design to not look disabled and instead have empty boxes when unselected. I think it might also be good to apply standard patterns and use square for multi. |
@asangma Agreed, either using the circle-empty + check-circle-f or square and square-check-f here would clear this up. |
@macandcheese I could also see something like an |
We have But I think having a default icon that is always present to represent "unselected" would be a good start. It could use a lighter fill to prevent the list from being too visually cluttered with those unselected items. (May want to adjust the padding here so the selection icons are more equally spaced) |
💯 |
And yeah...the spacing needs some love. :) |
Suggested spacing between the selection icon and the text: |
Figma designs available for updated selection iconography and tweaks to the border selection appearance to retain visibility when focused. Related designs for other components are included for reference. We plan to look more deeply at hover states as part of a future system-wide appearance effort. |
Hey all, with this issue the default hover pointer was changed for the list item - would it be possible to keep that and re-visit hover states? Maybe checking with folks? We have discussed before we have a pattern of using the list item in the style of a button for a flow-like ux. I can try track down other discussions we have had on this |
@ethanbdev for the hover to be present, the selctionMode should be set to something other than "none". Otherwise this could be done using CSS token variables. |
Related: #6123 |
Hey, I linked the issue with the original discussion on this, will that no longer be supported? |
@geospatialem maybe we need to discuss this one. Its odd for a list with no selection to have a hover and pointer. Maybe we add another selectionAppearance for drill in or "none" or a separate drill in component altogether. |
Another option here is Menu Items, here is an example from the documentation with Flow / Flow Item and Menu / Menu Item: https://codepen.io/mac_and_cheese/pen/qBvrQOz?editors=1000 |
I think the challenge is our apps are using calcite-list like a list of buttons, not as a list of dependent selectable items or non-interactive elements. This pattern is relatively common in our apps right now, and it looks like is part of the Figma designs for this issue (selectionMode="none" has hover and pressed states) If it's helpful, another area this pattern is used in web analysis is to show a list of input layers, where clicking on the layer should open a dialog to replace that layer, and clicking the slotted "x" should remove that layer from the list |
Reopening to revert the installation above, and discuss alternatives for future implementation to ensure precious support mentioned in #6700 (comment) and #6700 (comment). The revert will be part of an upcoming maintenance release targeted prior to R1. cc @ethanbdev @mpayson |
@mpayson not sure if this changes the selectionMode need, but I do find it strange the List Item itself is triggering that Replace Layer action. It seems like something that could be invoked from an action within the List Item itself: |
**Related Issue:** #6700 ## Summary It was decided that the majority of cases use the layer list to perform some kind of action so the default should be to have hover and pointer styling by default. In the future, we may add another selectionMode to provide a better UX for "non interactive" lists. Further information: #6123 (comment) - Always has the hover and pointer styling on a list item regardless of selectionMode - Add e2e test
Installed and assigned for verification. |
The default hover pointer change has been reverted and is verified in A new issue has been created to add a new selection mode in the future, while also supporting the pointer, via #8634. Closing the above as verified. |
Description
We've had users share that the unselected state of the calcite list doesnt immediately communicate it is selectable. When one or more items is selected by default it is not as critical, However for lists where there is no default selection it just looks like empty space and users are confused
Acceptance Criteria
Current
Desired
Relevant Info
No response
Which Component
calcite list / calcite list item
Example Use Case
No response
Priority impact
p3 - want for upcoming milestone
Esri team
ArcGIS Map Viewer
The text was updated successfully, but these errors were encountered: