Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select: update chevron colors and hover/pressed background color #7714

Closed
2 of 3 tasks
Tracked by #7703
ashetland opened this issue Sep 8, 2023 · 4 comments
Closed
2 of 3 tasks
Tracked by #7703

Select: update chevron colors and hover/pressed background color #7714

ashetland opened this issue Sep 8, 2023 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Milestone
2024-04-30 - Apr ...

Comments

@ashetland
Copy link

ashetland commented Sep 8, 2023 •
edited by geospatialem
Loading

Check existing issues

Actual Behavior

Select's chevrons are ui-text-2 in all states. The background also changes to foreground-2 when hovered and pressed.

image

Expected Behavior

For system consistency, chevrons should be ui-text-3 when idle, ui-text-1 when hovered or pressed, and the background color should not change from foreground-1.

image

Reproduction Sample

https://codepen.io/ashetland/pen/MWZpgRd

Reproduction Steps

Interact with Select.

Reproduction Version

v1.8.0

Relevant Info

Figma designs for Select here.

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (design)
@ashetland ashetland added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 8, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. Calcite (design) Issues logged by Calcite designers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Sep 8, 2023
@ashetland ashetland mentioned this issue Sep 8, 2023
Closed
5 tasks
@ashetland ashetland added design Issues that need design consultation prior to development. ready for dev Issues ready for development implementation. labels Sep 8, 2023
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Sep 8, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@geospatialem geospatialem added the good first issue Issues that can be worked on by contributors new to calcite-components. label Sep 21, 2023
@geospatialem geospatialem added this to the 2024 March Priorities milestone Nov 22, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 22, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
@brittneytewks
Copy link

Removed Figma changes label as this will be tracked in monday.com

@aPreciado88 aPreciado88 self-assigned this Apr 18, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Apr 18, 2024
@aPreciado88 aPreciado88 removed this from the 2024-07-30 - Jul Release milestone Apr 18, 2024
@aPreciado88 aPreciado88 added this to the 2024-04-30 - Apr Release milestone Apr 18, 2024
@aPreciado88 aPreciado88 added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Apr 19, 2024
@aPreciado88 aPreciado88 mentioned this issue Apr 19, 2024
Merged
aPreciado88 added a commit that referenced this issue Apr 24, 2024
@aPreciado88
fix(select): update the focus and hover chevron icon color and select…
b187340 
… focus and hover background color (#9160)

**Related Issue:**
[7714](#7714)

### Summary 
This updates `select` chevron colors to be `--calcite-color-text-3` when
idle and `--calcite-color-text-1` when hovered or pressed.
This also updates `select` background color to `bg-foreground-1` when
hovered or pressed.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Apr 24, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Apr 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Apr 25, 2024

🍠 Verified on 2.8.0-next.10

@DitwanP DitwanP closed this as completed Apr 25, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2024-04-30 - Apr Release
Development

No branches or pull requests
5 participants
@geospatialem @DitwanP @ashetland @brittneytewks @aPreciado88