Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'\n' in token output files causing issues in Windows #8350

Closed
1 task done
alisonailea opened this issue Dec 6, 2023 · 2 comments
Closed
1 task done

'\n' in token output files causing issues in Windows #8350

alisonailea opened this issue Dec 6, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2023 December Pri...

Comments

@alisonailea
Copy link
Contributor

alisonailea commented Dec 6, 2023 •
edited
Loading

Check existing issues

Actual Behavior

'\n' is written into platform output in tokens

Expected Behavior

tokens transformer should use npm os.EOL or Prettier.format()

Reproduction Sample

N/a

Reproduction Steps

  1. try to run the token transformer on a windows machine
  2. observe the token transformer fails to build

Reproduction Version

2.0

Relevant Info

Originally brought up by Ben in #8344 (review)

Regression?

No response

Priority impact

p1 - need for current milestone

Impact

Blocking usage of token output files on Windows machines

Calcite package

  • @esri/calcite-design-tokens

Esri team

Calcite (dev)
@alisonailea alisonailea added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 6, 2023
@github-actions github-actions bot added impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. Calcite (dev) Issues logged by Calcite developers. labels Dec 6, 2023
@alisonailea alisonailea self-assigned this Dec 6, 2023
@alisonailea alisonailea added 2 - in development Issues that are actively being worked on. p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed 0 - new New issues that need assignment. labels Dec 6, 2023
@alisonailea alisonailea added this to the 2023 December Priorities milestone Dec 6, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Dec 6, 2023
@alisonailea alisonailea added the estimate - 3 A day or two of work, likely requires updates to tests. label Dec 6, 2023
@alisonailea alisonailea mentioned this issue Dec 6, 2023
Merged
alisonailea added a commit that referenced this issue Dec 7, 2023
@alisonailea
fix: replace "\n" to support Windows for tokens output (#8352)
02cf5d5 
**Related Issue:** #8350

## Summary

Fixes an issue that was causing problems in Windows by handing off
control of formatting to the experts and by experts I mean Prettier.
@alisonailea alisonailea added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 7, 2023
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned alisonailea Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Installed and assigned for verification.

@DitwanP DitwanP removed their assignment Dec 13, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 18, 2023
@geospatialem
Copy link
Member

Verified on the main branch with Windows and git bash with the demo pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
3 participants
@alisonailea @geospatialem @DitwanP