Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close button in tab-titles are slightly misaligned #8772

Closed
2 of 6 tasks
jcfranco opened this issue Feb 16, 2024 · 3 comments
Closed
2 of 6 tasks

Close button in tab-titles are slightly misaligned #8772

jcfranco opened this issue Feb 16, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - design - sm Small design effort; 1-4 days of design work impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Milestone
2024-07-31 - Jul ...

Comments

@jcfranco
Copy link
Member

Check existing issues

Actual Behavior

The close button is positioned flush on the top, but is not aligned with the bottom border.

Screenshot 2024-02-16 at 1 58 49 PM

Screenshot 2024-02-16 at 3 01 18 PM

Expected Behavior

The close button should either be flush or have the same offset on both top/bottom sides.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/tabs/

Reproduction Steps

  1. Enable the closable prop on the tab-title
  2. Click on the component and tab to the close-button

Reproduction Version

2.5.1

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design Issues that need design consultation prior to development. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 16, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Feb 16, 2024
@jcfranco jcfranco mentioned this issue Feb 17, 2024
Merged
@brittneytewks brittneytewks added this to the 2024-03-26 - Mar Release milestone Mar 4, 2024
@brittneytewks brittneytewks added p - medium Issue is non core or affecting less that 60% of people using the library estimate - design - sm Small design effort; 1-4 days of design work and removed needs triage Planning workflow - pending design/dev review. labels Mar 4, 2024
@brittneytewks brittneytewks removed this from the 2024-03-26 - Mar Release milestone Mar 21, 2024
@macandcheese macandcheese added this to the 2024-04-30 - Apr Release milestone Mar 25, 2024
@macandcheese macandcheese added ready for dev Issues ready for development implementation. 1 - assigned Issues that are assigned to a sprint and a team member. and removed design Issues that need design consultation prior to development. 0 - new New issues that need assignment. labels Mar 25, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Mar 25, 2024
@github-actions github-actions bot removed this from the 2024-04-30 - Apr Release milestone Mar 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@macandcheese macandcheese self-assigned this Mar 25, 2024
@macandcheese macandcheese added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Mar 25, 2024
@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 10, 2024
@macandcheese macandcheese mentioned this issue Jun 22, 2024
Merged
macandcheese added a commit that referenced this issue Jul 25, 2024
@macandcheese
fix(tabs): Update tab title indicator display (#9666)
d570023 
**Related Issue:** #8800, #8772 

## Summary

Removes the previous selection indicator behavior and moves the styling
to the Tab Title component itself. Removes associated stale code and
tests. Small visual tweaks to resolve alignment and spacing issues.
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 25, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned macandcheese Jul 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jul 25, 2024

🍡 Verified on 2.11.0-next.23 👌
image
image

@DitwanP DitwanP closed this as completed Jul 25, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 25, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@macandcheese @github-actions
fix(tabs): Update tab title indicator display (#9666)
5f0914b 
**Related Issue:** #8800, #8772 

## Summary

Removes the previous selection indicator behavior and moves the styling
to the Tab Title component itself. Removes associated stale code and
tests. Small visual tweaks to resolve alignment and spacing issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - design - sm Small design effort; 1-4 days of design work impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
5 participants
@jcfranco @macandcheese @geospatialem @DitwanP @brittneytewks