Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up fake Storybook knobs and set up controls for simple stories #9084

Closed
jcfranco opened this issue Apr 8, 2024 · 2 comments
Closed

Clean up fake Storybook knobs and set up controls for simple stories #9084

jcfranco opened this issue Apr 8, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library tooling Issues relating to build system fixes or improvements.
Milestone
2024-05-28 - May ...

Comments

@jcfranco
Copy link
Member

jcfranco commented Apr 8, 2024

Summary

#9030 introduced fake knobs to ease migration to Storybook v8 as @storybook/addon-knobs is no longer supported. Knobs used in simple stories should be restored via @storybook/addon-controls and any other knob-usage should be cleaned up.

Desired Outcome

  1. Replace knobs with controls for simple stories
  2. Remove knobs used in all other stories
  3. Drop createComponentHTML and related utils and replace each story using this with HTML instead.

Resources

createComponentHTML
filterComponentAttributes
Example of story using ☝️
https://storybook.js.org/docs/essentials/controls
@jcfranco jcfranco added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 8, 2024
@aPreciado88 aPreciado88 self-assigned this May 1, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 1, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label May 1, 2024
@aPreciado88 aPreciado88 added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels May 1, 2024
@jcfranco jcfranco mentioned this issue May 7, 2024
Closed
95 tasks
@aPreciado88 aPreciado88 mentioned this issue May 21, 2024
Merged
aPreciado88 added a commit that referenced this issue May 28, 2024
@aPreciado88
refactor(storybook): replace fake knobs with controls for simple stor…
22b2fb1 
…ies (#9385)

**Related Issue:**
[9084](#9084)

## Summary 
-Replaces knobs with controls for `simple` stories.
-Removes knobs used in all other stories.
-Replaces usage of `createComponentHTML` and related utils with HTML.
@geospatialem geospatialem added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 28, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 May 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. labels May 28, 2024
@DitwanP
Copy link
Contributor

DitwanP commented May 30, 2024

🍡 Verified locally

@DitwanP DitwanP closed this as completed May 30, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @DitwanP @aPreciado88