Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooling] Add @esri/calcite-ui-icons to the monorepo packages #9255

Closed
geospatialem opened this issue May 3, 2024 · 2 comments · Fixed by #9835
Closed

[Tooling] Add @esri/calcite-ui-icons to the monorepo packages #9255

geospatialem opened this issue May 3, 2024 · 2 comments · Fixed by #9835
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library tooling Issues relating to build system fixes or improvements.
Milestone
2024-07-31 - Jul ...

Comments

@geospatialem
Copy link
Member

Summary

Add the calcite-ui-icons repo, to the Calcite monorepo packages.

Part of the monorepo package epic from #7122

Desired Outcome

Adding more Calcite packages to the repo and splitting existing functionality into encapsulated workspaces will improve maintainability and discoverability.

Resources

Additional discussion and context is also linked in #7122.
@geospatialem geospatialem added tooling Issues relating to build system fixes or improvements. 1 - assigned Issues that are assigned to a sprint and a team member. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. labels May 3, 2024
@geospatialem geospatialem mentioned this issue May 3, 2024
Open
13 tasks
@benelan benelan mentioned this issue Jul 23, 2024
Merged
@benelan benelan linked a pull request Jul 23, 2024 that will close this issue
chore: add calcite-ui-icons to monorepo #9835
Merged
@benelan benelan added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 23, 2024
benelan added a commit that referenced this issue Jul 30, 2024
@benelan
chore: add calcite-ui-icons to monorepo (#9835)
1b22e70 
**Related Issue:** #9255

## Summary

Good news, everyone! `@esri/calcite-ui-icons` is joining the Calcite
Design System monorepo. This change will ensure Calcite components
always uses the latest and greatest version of the icons. Additionally,
the icons will benefit from the monorepo's continuous integration,
including automatic changelog generation and deployment. This will give
the designers more time to do what they do best!

Some much needed cleanup was accomplished during this transition. The
following items will no longer be [published to
npm](https://unpkg.com/browse/@esri/calcite-ui-icons@3.29.0/):

```
.github/*
CONTRIBUTE.md
bin/build.js
bin/cli.js
bin/convert-mobile.js
bin/optimize.js
bin/path-data.js
bin/server.js
bin/templates/*
bower.json
docs/app.js
docs/index.html
docs/resources/*
launch-calcite.command
launch-meridian.command
```

Additionally, the autogenerated, build files will not longer be
committed into version control. This includes:

```
docs/icons.json
index.d.ts
index.js
js/*
sprite-16.svg
sprite-24.svg
sprite-32.svg
```

These files can be generated via `npm run build`. The build files will
be attached to GitHub releases for users who do not consume the icons
via NPM.

Note that I removed `bower.json` since [they
recommended](https://bower.io/blog/2017/how-to-migrate-away-from-bower/)
using other software back in 2017, and there hasn't been any activity in
the [repo](https://github.com/bower/bower) for a few years now. However,
I'm open to deprecating bower support and removing it in the next major
release if people prefer that route.

Release-As: 3.30.0
@benelan benelan added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 30, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned benelan Jul 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@benelan benelan reopened this Jul 30, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@benelan @github-actions
chore: add calcite-ui-icons to monorepo (#9835)
05264ea 
**Related Issue:** #9255

## Summary

Good news, everyone! `@esri/calcite-ui-icons` is joining the Calcite
Design System monorepo. This change will ensure Calcite components
always uses the latest and greatest version of the icons. Additionally,
the icons will benefit from the monorepo's continuous integration,
including automatic changelog generation and deployment. This will give
the designers more time to do what they do best!

Some much needed cleanup was accomplished during this transition. The
following items will no longer be [published to
npm](https://unpkg.com/browse/@esri/calcite-ui-icons@3.29.0/):

```
.github/*
CONTRIBUTE.md
bin/build.js
bin/cli.js
bin/convert-mobile.js
bin/optimize.js
bin/path-data.js
bin/server.js
bin/templates/*
bower.json
docs/app.js
docs/index.html
docs/resources/*
launch-calcite.command
launch-meridian.command
```

Additionally, the autogenerated, build files will not longer be
committed into version control. This includes:

```
docs/icons.json
index.d.ts
index.js
js/*
sprite-16.svg
sprite-24.svg
sprite-32.svg
```

These files can be generated via `npm run build`. The build files will
be attached to GitHub releases for users who do not consume the icons
via NPM.

Note that I removed `bower.json` since [they
recommended](https://bower.io/blog/2017/how-to-migrate-away-from-bower/)
using other software back in 2017, and there hasn't been any activity in
the [repo](https://github.com/bower/bower) for a few years now. However,
I'm open to deprecating bower support and removing it in the next major
release if people prefer that route.

Release-As: 3.30.0
@DitwanP
Copy link
Contributor

DitwanP commented Jul 30, 2024

🍡 Verified locally on dev 👌

@DitwanP DitwanP closed this as completed Jul 30, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 30, 2024
@geospatialem geospatialem mentioned this issue Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

Successfully merging a pull request may close this issue.

chore: add calcite-ui-icons to monorepo Esri/calcite-design-system
3 participants
@geospatialem @benelan @DitwanP