Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialization regression in components output target #9468

Closed
2 of 6 tasks
geospatialem opened this issue May 30, 2024 · 2 comments
Closed
2 of 6 tasks

Initialization regression in components output target #9468

geospatialem opened this issue May 30, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
April 2.8.5 hotfi...

Comments

@geospatialem
Copy link
Member

geospatialem commented May 30, 2024 •
edited by jcfranco
Loading

Check existing issues

Actual Behavior

As a result of upgrading from 2.8.3 to 2.8.4 there were some failing screenshot tests from internal teams. We should restore the componentDidLoad hooks to accommodate changes in initialization.

Expected Behavior

No failing screenshot tests

Reproduction Sample

https://stackblitz.com/edit/github-ojdkyo-zgju9e

Reproduction Steps

  1. Observe component's initial value set when using v1.8.3.
  2. Update package.json to use @esri/calcite-components@2.8.4. Notice value is not displayed in the input.

Reproduction Version

3.8.4

Relevant Info

Seems to pertain to be related to #9443

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

High

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 30, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels May 30, 2024
@geospatialem geospatialem added this to the May hotfix release milestone May 30, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 30, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels May 30, 2024
@jcfranco jcfranco changed the title Restore componentDidLoad hooks Initialization logic regression in components output target May 30, 2024
@jcfranco jcfranco changed the title Initialization logic regression in components output target Initialization regression in components output target May 30, 2024
@jcfranco jcfranco mentioned this issue May 30, 2024
Merged
jcfranco added a commit that referenced this issue May 30, 2024
@jcfranco
fix(combobox, dropdown, input-date-picker, popover, tooltip): fix ini…
0043aa7 
…tialization logic in components output target (#9470)

**Related Issue:** #9468

## Summary

#9443 introduced a
regression caused by using the `componentOnLoad` util to consolidate
initialization logic shared between `connectedCallback` and
`componentDidLoad`. The util appears to resolve at a different time in
the `components` output target, which messed up with initialization of
certain components.

**Note**: there are no accompanying tests as this is not reproducible in
the test environment, which uses the lazy-loaded output.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco May 30, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 31, 2024
@geospatialem
Copy link
Member Author

Verified in 2.8.5

benelan pushed a commit that referenced this issue Jun 25, 2024
@jcfranco @benelan
fix(combobox, dropdown, input-date-picker, popover, tooltip): fix ini…
5dcc3f5 
…tialization logic in components output target (#9470)

**Related Issue:** #9468

## Summary

#9443 introduced a
regression caused by using the `componentOnLoad` util to consolidate
initialization logic shared between `connectedCallback` and
`componentDidLoad`. The util appears to resolve at a different time in
the `components` output target, which messed up with initialization of
certain components.

**Note**: there are no accompanying tests as this is not reproducible in
the test environment, which uses the lazy-loaded output.
benelan pushed a commit that referenced this issue Jun 25, 2024
@jcfranco @benelan
fix(combobox, dropdown, input-date-picker, popover, tooltip): fix ini…
087bc92 
…tialization logic in components output target (#9470)

**Related Issue:** #9468

## Summary

#9443 introduced a
regression caused by using the `componentOnLoad` util to consolidate
initialization logic shared between `connectedCallback` and
`componentDidLoad`. The util appears to resolve at a different time in
the `components` output target, which messed up with initialization of
certain components.

**Note**: there are no accompanying tests as this is not reproducible in
the test environment, which uses the lazy-loaded output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
April 2.8.5 hotfix release
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP