Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add metadata support to combobox items #9796

Closed
2 of 6 tasks
jcfranco opened this issue Jul 16, 2024 · 2 comments
Closed
2 of 6 tasks

add metadata support to combobox items #9796

jcfranco opened this issue Jul 16, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-07-31 - Jul ...

Comments

@jcfranco
Copy link
Member

Check existing issues

Description

Adding item metadata support to combobox would help with filtering and also be consistent with other components with filtering capabilities.

Acceptance Criteria

Add a metadata property to combobox-item, which is used in combobox filtering.

Relevant Info

No response

Which Component

calcite-combobox, calcite-combobox-item.

Example Use Case

No response

Priority impact

impact - p1 - need for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@jcfranco jcfranco added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 16, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jul 16, 2024
@jcfranco jcfranco changed the title add support for metadata to combobox items add metadata support to combobox items Jul 16, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jul 19, 2024
@jcfranco jcfranco self-assigned this Jul 19, 2024
@jcfranco jcfranco added estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Jul 19, 2024
@jcfranco jcfranco added this to the 2024-07-30 - Jul Release milestone Jul 19, 2024
This was referenced Jul 19, 2024
Merged
Open
jcfranco added a commit that referenced this issue Jul 22, 2024
@jcfranco
feat(combobox, combobox-item): add metadata support for filtering (#…
bd90f63 
…9819)

**Related Issue:** #9796 

## Summary

This update allows additional data to be set per item to be included for
filtering.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned jcfranco Jul 22, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jul 25, 2024

🍡 Verified on 2.11.0-next.23
https://codepen.io/Ditwan-Price/pen/oNrzJJv?editors=1010

@DitwanP DitwanP closed this as completed Jul 25, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 25, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@jcfranco @github-actions
feat(combobox, combobox-item): add metadata support for filtering (#…
5de7787 
…9819)

**Related Issue:** #9796 

## Summary

This update allows additional data to be set per item to be included for
filtering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP