fix(combobox-item): fix rendering tied to named-slot content #10450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
github-actions
bot
added
the
bug
driskull
commented
Sep 30, 2024
| // -------------------------------------------------------------------------- | ||
| // | ||
| // Lifecycle | ||
| // | ||
| // -------------------------------------------------------------------------- | ||
|
|
||
| connectedCallback(): void { | ||
| // todo: refactor: if grandparent is removed, this will not update | ||
| this.ancestors = getAncestors(this.el); |
There was a problem hiding this comment.
if grandparent is removed, I think this would get stale and incorrect. I don't think it would update because connectedCallback of a grandparent wouldn't trigger anything here.
Do we want to open an issue for this?
There was a problem hiding this comment.
Yeah, we should revisit this. Can you create an issue to refactor this logic and possibly move it up to combobox?
driskull
changed the title
jcfranco
approved these changes
Sep 30, 2024
| // -------------------------------------------------------------------------- | ||
| // | ||
| // Lifecycle | ||
| // | ||
| // -------------------------------------------------------------------------- | ||
|
|
||
| connectedCallback(): void { | ||
| // todo: refactor: if grandparent is removed, this will not update | ||
| this.ancestors = getAncestors(this.el); |
There was a problem hiding this comment.
Yeah, we should revisit this. Can you create an issue to refactor this logic and possibly move it up to combobox?
5 tasks
driskull
added
the
pr ready for visual snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6059
Summary
getSlottedutilityslotchangeevent and@Statevariables to update the display of elements.