fix(inline-editable): fix rendering tied to default slot content #10456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
25 tasks
driskull
commented
Sep 30, 2024
| mutationObserverCallback(): void { | ||
| // todo: kind of odd to be setting scale based on a slotted element scale. | ||
| // would require a scale event to properly handle this which would be better than a mutation observer | ||
| this.scale = this.scale || this.inputElement?.scale; |
There was a problem hiding this comment.
Its kind of odd to be setting scale based on a slotted element's scale.
To handle this better, an internal event for scale change would be needed.
IMO we should just remove this. Thoughts?
There was a problem hiding this comment.
The problem with this is that if inputElements scale changes after being slotted, this wouldn't get picked up.
If inputElement is replaced after initialization then the scale is already set at that point too.
There was a problem hiding this comment.
Agreed. Can you create an issue for this?
@geospatialem @brittneytewks We can plan for removal in a breaking change.
driskull
changed the title
jcfranco
approved these changes
Oct 1, 2024
| mutationObserverCallback(): void { | ||
| // todo: kind of odd to be setting scale based on a slotted element scale. | ||
| // would require a scale event to properly handle this which would be better than a mutation observer | ||
| this.scale = this.scale || this.inputElement?.scale; |
There was a problem hiding this comment.
Agreed. Can you create an issue for this?
@geospatialem @brittneytewks We can plan for removal in a breaking change.
driskull
changed the title
driskull
added
the
pr ready for visual snapshots
6 tasks
benelan
added a commit
that referenced
this pull request
Oct 7, 2024
* origin/dev: (230 commits) chore: release next chore(sort-handle): add messages (#10474) feat(accordion-item): stretch slotted actions to fill its height (#9250) chore: release next feat(dialog, modal, popover, input-date-picker, input-time-picker, sheet): support stacked component sequential closing with escape (#9231) chore: remove commented-out code (#10478) chore: add cssrem VSCode extension recommendation (#10300) docs(accordion-item): fix deprecation tag (#10479) chore: release next feat(stepper-item): update component's active state background color. (#10475) refactor: use `requestAnimationFrame` to replace `readTask` (#10432) chore: release next fix(tip): fix rendering tied to named-slot content (#10470) ci: compile estimate totals per milestone (#10442) chore: release next fix(modal): fix rendering tied to named-slot content (#10469) chore: release next fix(shell-center-row): fix rendering tied to named-slot content (#10451) fix(inline-editable): fix rendering tied to default slot content (#10456) fix(input, input-number, input-text): should not set slotted actions to be disabled (#10458) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6059
Summary
getSlottedutilityslotchangeevent