Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): update content background color to match modal #10856

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix(dialog): update content background color to match modal #10856

merged 1 commit into from
Nov 26, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Nov 23, 2024 •
edited
Loading

Related Issue: #10809

Summary

Updates dialog’s content background color to be consistent with modal, easing the team’s migration efforts.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Nov 23, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 23, 2024
driskull
driskull approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ashetland
Copy link

ashetland commented Nov 26, 2024 •
edited
Loading

All the chromatic diffs were false positives. I did not see a diff for Dialog, however. With the color change, there should be one, right?

@ashetland
Copy link

I do see the update to foreground.1 when I look at Dialog, but chromatic didn't catch the diff for some reason. 🤷

@jcfranco
Copy link
Member Author

@ashetland Not sure why Chromatic didn't catch it. 🤔❓

@jcfranco jcfranco removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 26, 2024
@jcfranco
Copy link
Member Author

I'll run another screenshot build to see if it catches it.

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 26, 2024
ashetland
ashetland approved these changes Nov 26, 2024
View reviewed changes
Copy link

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chromatic still isn't catching the diff for some reason, but we're good to go. All the other diffs were false positives.

@jcfranco jcfranco merged commit 0fd6560 into dev Nov 26, 2024
21 checks passed
@jcfranco jcfranco deleted the jcfranco/10809-change-dialog-background-color branch November 26, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashetland ashetland ashetland approved these changes

@driskull driskull driskull approved these changes

@SkyeSeitz SkyeSeitz Awaiting requested review from SkyeSeitz

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

Successfully merging this pull request may close these issues.
3 participants
@jcfranco @ashetland @driskull