Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tab-nav): stabilize test #8356

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 6, 2023

Related Issue: N/A

Summary

Waits for changes after interacting with the tab title to account for some internal eventing going on.

@github-actions github-actions bot added the testing Issues related to automated or manual testing. label Dec 6, 2023
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 6, 2023
@jcfranco
Copy link
Member Author

jcfranco commented Dec 8, 2023

Ran the tests about 17 times and the updated test appears to be stable.

@jcfranco jcfranco marked this pull request as ready for review December 8, 2023 17:15
@jcfranco jcfranco requested a review from a team as a code owner December 8, 2023 17:15
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit 1ee70f2 into main Dec 8, 2023
12 checks passed
@jcfranco jcfranco deleted the jcfranco/stabilize-tab-nav-test branch December 8, 2023 19:25
@github-actions github-actions bot added this to the 2023 December Priorities milestone Dec 8, 2023
benelan added a commit that referenced this pull request Dec 8, 2023
…ssage

* origin/main:
  build(node): bump node version to v20 (latest LTS) (#8381)
  build: swap ts-node for tsx (#8196)
  chore: release next
  build(deps): update dependency @types/prettier to v2.7.3 (#8375)
  build(deps): update dependency ng-packagr to v17.0.2 (#8362)
  test(tab-nav): stabilize test (#8356)
  fix(list-item): drag grid cell should be accessible via arrow keys. (#8353)
  chore: release next
  feat(list): Add `calciteListDragStart` and `calciteListDragEnd` events for when a drag starts and ends. (#8361)
  build(deps): update dependency tailwindcss to v3.3.6 (#8376)
  ci(eslint): disable eslint rules that are failing (#8372)
  chore: release next
  fix: replace "\n" to support Windows for tokens output (#8352)
  chore: release next
  ci(next): install deps before running npm scripts (#8370)
  feat: provide legacy CSS custom props for backwards compatibility (#8355)
  fix(input-date-picker): no longer emits redundant change event (#8341)
  fix(shell-panel): adds border at the start when slotted in `panel-end` (#8314)
  build(deps): update dependency sortablejs to v1.15.1 (#8364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip visual snapshots Pull requests that do not need visual regression testing. testing Issues related to automated or manual testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants