Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: fix(panel, flow-item): remove overflow rule #8711

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Feb 9, 2024

Related Issue: #8028 #8611

Summary

  • Reverts previous pull request which removes overflow:hidden on the host of the panel and flow-item components.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Feb 9, 2024
@driskull driskull changed the title revert(panel, flow-item): reverts overflow rule. #8055 #8028 #8611 revert(panel, flow-item): reverts overflow rule Feb 9, 2024
@driskull driskull added low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 9, 2024
@driskull driskull marked this pull request as ready for review February 9, 2024 22:56
@driskull driskull requested a review from a team as a code owner February 9, 2024 22:56
@driskull
Copy link
Member Author

Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Could you update the PR title to the following?

revert: fix(panel, flow-item): remove overflow rule

I'll update our guidelines with this info for consistency. cc @benelan

@driskull driskull changed the title revert(panel, flow-item): reverts overflow rule revert: fix(panel, flow-item): remove overflow rule Feb 13, 2024
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 13, 2024
@driskull driskull merged commit 21226ce into main Feb 13, 2024
18 checks passed
@driskull driskull deleted the dris0000/revert-8055 branch February 13, 2024 23:54
jcfranco pushed a commit that referenced this pull request Feb 15, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.5.0</summary>

##
[2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.4.0...@esri/calcite-components@2.5.0)
(2024-02-15)


### Features

* **stepper:** Add horizontal-single layout
([#8742](#8742))
([c34bc4f](c34bc4f))
* **table:** Add `interactionMode` property to control focus behavior
([#8686](#8686))
([0cb78c0](0cb78c0))
* **table:** Improve accessibility of interaction-mode: static Table
([#8754](#8754))
([eead1b5](eead1b5))
* **tile:** Add responsive layout features
([#8691](#8691))
([f4f872e](f4f872e))


### Bug Fixes

* **color-picker:** Alpha-channel slider scope updates to reflect
current opacity
([#8700](#8700))
([cd0b532](cd0b532))
* **combobox:** Avoid inline-start padding on combobox label when icon
is displayed
([#8672](#8672))
([9eb680a](9eb680a))
* Don't override existing validationMessage when displaying after form
submission
([#8690](#8690))
([3076220](3076220))
* Fix dragging items on a mobile device
([#8751](#8751))
([dc11612](dc11612))
* Fix styling when dragging items on a mobile device
([#8750](#8750))
([7c01e6e](7c01e6e))
* **input, input-number, input-text, text-area:** Ensure all applicable
props are considered in form validation
([#8655](#8655))
([6de8534](6de8534))
* **list-item:** Fix slotted list border styling.
([#8712](#8712))
([855f98d](855f98d))
* **loader:** Optimize animation performance
([#8714](#8714))
([1ed8a01](1ed8a01))
* **preset:** Add back legacy token for calcite-ui-focus-color
([#8694](#8694))
([1d1b933](1d1b933))
* Prevent interaction when component is disabled after initialization
(Firefox)
([#8746](#8746))
([aa84182](aa84182))
* **stepper:** No longer adds default `min-width` for items when
`layout='horizontal'`
([#8758](#8758))
([23a7439](23a7439))


### Reverts

* Fix(panel, flow-item): remove overflow rule
([#8711](#8711))
([21226ce](21226ce))
</details>

<details><summary>@esri/calcite-components-angular: 2.5.0</summary>

##
[2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.4.0...@esri/calcite-components-angular@2.5.0)
(2024-02-15)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.5.0-next.6 to ^2.5.0
</details>

<details><summary>@esri/calcite-components-react: 2.5.0</summary>

##
[2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.4.0...@esri/calcite-components-react@2.5.0)
(2024-02-15)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.5.0-next.6 to ^2.5.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benelan added a commit that referenced this pull request Feb 15, 2024
* origin/main: (22 commits)
  fix: ensure ui-icons are copied from correct path (#8761)
  build(changelog): fix synced version group name (#8762)
  chore: release main (#8706)
  fix(stepper): no longer adds default `min-width` for items when `layout='horizontal'` (#8758)
  build(deps): update dependency @floating-ui/dom to v1.6.3 (#8759)
  chore: release next
  feat(table): Improve accessibility of interaction-mode: static Table (#8754)
  chore: release next
  fix: fix dragging items on a mobile device (#8751)
  build(deps): update dependency @esri/calcite-ui-icons to v3.26.4 (#8752)
  chore: release next
  fix: prevent interaction when component is disabled after initialization (Firefox) (#8746)
  fix: fix styling when dragging items on a mobile device (#8750)
  chore: release next
  feat(stepper): add horizontal-single layout (#8742)
  revert: fix(panel, flow-item): remove overflow rule (#8711)
  refactor(input): tidy up input spec test (#8733)
  chore: improve doc for createBreakpointStories helper (#8739)
  chore: release next
  feat(table): Add `interactionMode` property to control focus behavior (#8686)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants