Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent package patching on install #8766

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Feb 16, 2024

Related Issue: N/A

Summary

Cleans up package-patching scripts (introduced in #8751) to prevent them from running on calcite-components installs.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 16, 2024
@jcfranco
Copy link
Member Author

Worth noting that the patch is properly applied across dev/production builds (tested w/ clean builds).

@jcfranco jcfranco added low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 16, 2024
@jcfranco
Copy link
Member Author

Merging to proceed with today’s patch release. LMK if there’s anything that needs following up.

@jcfranco jcfranco merged commit fe18b1b into main Feb 16, 2024
16 of 17 checks passed
@jcfranco jcfranco deleted the jcfranco/keep-package-patching-internal branch February 16, 2024 01:58
jcfranco pushed a commit that referenced this pull request Feb 16, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.5.1</summary>

##
[2.5.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.5.0...@esri/calcite-components@2.5.1)
(2024-02-16)


### Bug Fixes

* Ensure ui-icons are copied from correct path
([#8761](#8761))
([3015a46](3015a46))
* Prevent package patching on install
([#8766](#8766))
([fe18b1b](fe18b1b))
</details>

<details><summary>@esri/calcite-components-angular: 2.5.1</summary>

##
[2.5.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.5.0...@esri/calcite-components-angular@2.5.1)
(2024-02-16)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.5.1-next.1 to ^2.5.1
</details>

<details><summary>@esri/calcite-components-react: 2.5.1</summary>

##
[2.5.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.5.0...@esri/calcite-components-react@2.5.1)
(2024-02-16)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.5.1-next.1 to ^2.5.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant