Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combobox): prevent spacebar from opening the menu while focusing on chip's close button #8909

Merged
merged 7 commits into from
Mar 13, 2024
Merged

fix(combobox): prevent spacebar from opening the menu while focusing on chip's close button #8909

merged 7 commits into from
Mar 13, 2024

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Mar 8, 2024 •
edited by DitwanP
Loading

Related Issue: #6777

Summary

Prevent spacebar from opening the menu while focusing on chip's close button.

BEGIN_COMMIT_OVERRIDE
Get lost
END_COMMIT_OVERRIDE

@Elijbet Elijbet changed the title fix(combobox) spacebar does not open menu while focusing on chip's close button fix(combobox): spacebar does not open menu while focusing on chip's close button Mar 8, 2024
@Elijbet Elijbet marked this pull request as ready for review March 8, 2024 20:06
@Elijbet Elijbet requested a review from a team as a code owner March 8, 2024 20:06
macandcheese
macandcheese requested changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we handle this in the Combobox component if possible?

packages/calcite-components/src/components.d.ts Outdated Show resolved Hide resolved
packages/calcite-components/src/components/chip/chip.tsx Outdated Show resolved Hide resolved
packages/calcite-components/src/components/combobox/combobox.e2e.ts Show resolved Hide resolved
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Mar 10, 2024
@Elijbet Elijbet added the skip visual snapshots Pull requests that do not need visual regression testing. label Mar 10, 2024
@Elijbet Elijbet changed the title fix(combobox): spacebar does not open menu while focusing on chip's close button fix(combobox): prevent spacebar from opening the menu while focusing on chip's close button Mar 12, 2024
jcfranco
jcfranco approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Elijbet Elijbet merged commit a1bae56 into main Mar 13, 2024
11 checks passed
@Elijbet Elijbet deleted the elijbet/6777-space-doesnot-open-combobox-menu-when-focusing-on-chip-close-button branch March 13, 2024 01:04
@github-actions github-actions bot added this to the 2024-03-26 - Mar Release milestone Mar 13, 2024
@calcite-admin calcite-admin mentioned this pull request Mar 12, 2024
Merged
@Elijbet Elijbet mentioned this pull request Mar 22, 2024
Merged
Elijbet added a commit that referenced this pull request Mar 25, 2024
@Elijbet
fix(combobox): prevent spacebar from opening the menu when focused on…
1a20d0e 
… chip's close button (#8990)

**Related Issue:** #6777

## Summary

Prevent spacebar from opening the menu when focused on chip's `close`
button.

Fixes a regression introduced in
#8909.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@alisonailea alisonailea alisonailea approved these changes

@macandcheese macandcheese macandcheese approved these changes

Assignees

@Elijbet Elijbet

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-03-26 - Mar Release
Development

Successfully merging this pull request may close these issues.
4 participants
@Elijbet @jcfranco @alisonailea @macandcheese