-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(accordion-item): stretch slotted actions to fill its height #9250
Merged
+48
−1
Merged
Changes from 10 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d1842b4
feat(accordion-item): stretch slotted actions to fill its height
josercarcamo 91c3fed
Merge branch 'main' into josercarcamo/6565-stretch-slotted-actions
josercarcamo 8323d22
Refactored code per code review and added UI test
josercarcamo 0878654
Added demo for slotted actions
josercarcamo 4e304f8
Merge branch 'josercarcamo/6565-stretch-slotted-actions' of github.co…
josercarcamo f8dbd61
Merge branch 'main' into josercarcamo/6565-stretch-slotted-actions
josercarcamo 39c2f87
Changed the UI test
josercarcamo dbc87e6
Merge branch 'main' into josercarcamo/6565-stretch-slotted-actions
josercarcamo 71b53a8
Trying different solution
josercarcamo ac8cf12
Removed items stretch
josercarcamo f4037f7
compeonts
josercarcamo ee6a1cb
Increased specificity of actions-start and added items-stretch
josercarcamo 22c4882
Removed unnecessary rule
josercarcamo 25fa2e8
Resolved conflicts
josercarcamo f396655
Merging
josercarcamo e92efd8
Modified solution to not stretch slot element; added actions-end to s…
josercarcamo 7ddbffb
Merge branch 'dev' into josercarcamo/6565-stretch-slotted-actions
josercarcamo 40ee644
Changed scale to 'l' to ensure actions stretch to fill their space
josercarcamo 7cd73bf
Merge branch 'dev' into josercarcamo/6565-stretch-slotted-actions
josercarcamo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this working @josercarcamo? Do we need some new screenshot tests to account for these changes?
I would have expected either
align-items:stretch
oralign-self:stretch
needs to be used to stretch the items by either using the::slotted
selector or some element within the shadow DOM of the component.Something like:
calcite-design-system/packages/calcite-components/src/components/list-item/list-item.scss
Line 78 in b069284
or
calcite-design-system/packages/calcite-components/src/components/list-item/list-item.scss
Lines 190 to 193 in b069284
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is working, at least with manual testing. I tried the "align-items: stretch" but it didn't work in this case. I actually tried to use the solution in alert.scss as shown below, but it didn't work.
.actions-end { @apply flex self-stretch; }
EDIT: Actually, your suggestion led me to a simpler solution. Testing and will push soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just wondering why this is doing anything. A slot element is just a placeholder and really isn't an element that needs to be styled.