Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use local placeholder image in html files #9392

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

driskull
Copy link
Member

@driskull driskull commented May 21, 2024

Related Issue: None

Summary

  • Use local placeholder image for images
  • Remove duplicate links for https://webapps-cdn.esri.com/CDN/fonts/v1.4.1/fonts.css
  • Update Maps SDK url to use the next version so it is always up to date.
  • Update links to external URLs to use http://www.esri.com
  • Update input value's that are links to be http://www.esri.com

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label May 21, 2024
@driskull driskull marked this pull request as ready for review May 21, 2024 23:20
@driskull driskull requested a review from a team as a code owner May 21, 2024 23:20
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We should look at having the linter catch this. eslint-html's no-restricted-attr-values looks promising.

@driskull
Copy link
Member Author

Yeah that would be great. Should we open an issue for it?

@driskull driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label May 22, 2024
@driskull driskull merged commit 4e23c10 into main May 22, 2024
13 checks passed
@driskull driskull deleted the dris0000/html-cleanup branch May 22, 2024 00:01
@jcfranco
Copy link
Member

@driskull An issue would be great, thanks!

macandcheese added a commit that referenced this pull request May 22, 2024
**Related Issue:** #9361 , #9392 

## Summary
Removes served images from stories and local demo. We keep them in `.md`
file, as these need to be hosted somewhere in order to work if the
samples are used in an external location. cc @driskull

Ideally, we could use map tiles or something
(https://codepen.io/mac_and_cheese/pen/XWwXXqx?editors=1000) for these,
but not sure how reliable those are.
@driskull
Copy link
Member Author

created issue #9396

benelan added a commit that referenced this pull request May 24, 2024
…x-constraint

* origin/main: (37 commits)
  build(deps): update dependency @stencil/core to v4.18.2 (#9266)
  refactor(stepper-item): drop unnecessary transitions (#9327)
  docs(contributing): add commit message formatting details (#9389)
  docs: update component READMEs (#9328)
  build: update browserslist db (#9263)
  chore: release next
  fix(tree): allow single select only and add indicator (#9405)
  chore: release next
  feat(split-button): Make dividers consistent (#9402)
  chore: release next
  feat(stepper, stepper-item): add separate change events to stepper and items (deprecates `calciteStepperItemChange` on the parent) (#9351)
  chore(tree): fix multiple selection-mode values set in slotted dropdown-groups (#9378)
  fix(dropdown-group): title scale with dropdown scale (#9360)
  chore: release next
  fix(tree): allow deselection in single selectionMode (#9363)
  chore: Update placeholder images in stories and demos (#9395)
  chore: use local placeholder image in html files (#9392)
  chore: release next
  chore: release hotfix (#9382)
  fix(combobox): fix error that occurs when a click is emitted when the component is appended to the DOM (#9380)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants