ci(provenance): add missing options from setup doc #9433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the deployment GitHub Actions according to steps in the npm doc, which I missed because I was looking at the 3rd party section below it. The GitHub doc about provenance doesn't mention permissions, so it might not be required. We had originally hardcoded an older version of Ubuntu in #5942 due to errors, but it was resolved in Stencil v4. npm-doc: https://docs.npmjs.com/generating-provenance-statements#publishing-packages-with-provenance-via-github-actions github-doc: https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages#publishing-packages-to-the-npm-registry
github-actions
bot
added
the
chore
benelan
added
the
skip visual snapshots
benelan
added a commit
that referenced
this pull request
May 29, 2024
…hes--main * origin/main: chore: release next ci: add repo url to package.json files for provenance (#9449) ci(provenance): add missing options from setup doc (#9433) chore: release hotfix (#9438) fix: defer floating-ui updating until component is connected and open (#9443) fix(combobox): fix error that occurs in dist-custom-elements (components) output when a click is emitted when the component is appended to the DOM (#9423)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9429
Summary
Update the deployment GitHub Actions according to steps in the npm provenance doc, which I missed because I was looking at the 3rd party section below it.
The GitHub provenance doc doesn't mention permissions, so it might not be required.
We had originally hardcoded an older version of Ubuntu in #5942 due to errors, but it was resolved in Stencil v4.