feat(shell-panel): deprecate float displayMode and add float-content and float-all #9795

josercarcamo · 2024-07-16T19:50:13Z

Related Issue: #7513

Summary

Replaced display mode "float" with "float-content" and added "float-all". Deprecated "float".

…ay-v2

driskull

Initial review

packages/calcite-components/src/components/action-bar/action-bar.tsx

packages/calcite-components/src/components/shell-panel/shell-panel.scss

packages/calcite-components/src/components/shell-panel/shell-panel.tsx

packages/calcite-components/src/components/action-bar/action-bar.tsx

…ay-v2

alisonailea

Make sure any token's you're adding align with the naming schema https://github.com/Esri/calcite-design-system/wiki/tokens-naming-schema

alisonailea · 2024-07-17T16:45:29Z

packages/calcite-components/src/components/shell-panel/shell-panel.scss

+:host([layout="vertical"][display-mode="content-detached"]) .content {
+  flex: 2;
+}
+
 :host([layout="vertical"][width-scale="s"]) .content {
  --calcite-shell-panel-width-internal: var(--calcite-shell-panel-width, 12vw);


the naming schema for these should be --calcite-internal-shell-panel-

I didn't add these tokens. They're pre-existing.

can you update them while you're there? They're already internal so there won't be any breaking changes to worry about.

packages/calcite-components/src/components/shell-panel/shell-panel.scss

…ay-v2

…github.com:Esri/calcite-design-system into josercarcamo/7513-shell-panel-add-float-display-v2

…ay-v2

…github.com:Esri/calcite-design-system into josercarcamo/7513-shell-panel-add-float-display-v2

…ay-v2

…github.com:Esri/calcite-design-system into josercarcamo/7513-shell-panel-add-float-display-v2

…ay-v2

josercarcamo · 2024-07-24T20:12:53Z

@driskull @alisonailea do you want to take another look?

…ay-v2

josercarcamo · 2024-07-25T20:20:53Z

@driskull one more review please.

driskull

Looks good! Can you just add displayMode to the PR title somehow?

And this shouldn't be merged in until Nov release. 👍

…ay-v2

josercarcamo · 2024-07-29T22:58:47Z

@driskull one last review please.

driskull

LGTM! just had some questions

driskull · 2024-07-29T23:01:13Z

packages/calcite-components/src/components/shell/shell.stories.ts

@@ -360,7 +360,7 @@ darkModeRTL_TestOnly.parameters = { themes: modesDarkDefault };

 export const closedPanels = (): string =>
  html(`<calcite-shell content-behind>
-  <calcite-shell-panel slot="panel-start" display-mode="float">
+  <calcite-shell-panel slot="panel-start" display-mode="float-content">


question: should these values remain float to keep test coverage for the deprecated float value? Applies to other changes below that are being changed from float to float-content.

driskull · 2024-07-29T23:02:41Z

packages/calcite-components/src/components/shell-panel/shell-panel.tsx

@@ -134,7 +138,7 @@ export class ShellPanel implements ConditionalSlotComponent, LocalizedComponent,
  @Prop({ reflect: true }) position: Extract<"start" | "end", Position> = "start";

  /**
-   * When `true` and `displayMode` is not `float`, the component's content area is resizable.
+   * When `true` and `displayMode` is not `float-content`, the component's content area is resizable.


question: should this doc still include float as well as float-content?

driskull · 2024-07-29T23:02:47Z

packages/calcite-components/src/components/shell-panel/shell-panel.tsx

  }

  /**
-   * When `displayMode` is `float`, specifies the maximum height of the component.
+   * When `displayMode` is `float-content`, specifies the maximum height of the component.


question: should this doc still include float as well as float-content?

driskull · 2024-07-29T23:05:52Z

packages/calcite-components/src/components/shell-panel/shell-panel.scss

- * @prop --calcite-shell-panel-max-height: When `layout` is `horizontal`, or `layout` is `vertical` and `displayMode` is `float`, specifies the maximum height of the component.
- * @prop --calcite-shell-panel-min-height: When `layout` is `horizontal`, or `layout` is `vertical` and `displayMode` is `float`, specifies the minimum height of the component.
- * @prop --calcite-shell-panel-detached-max-height: [Deprecated] Use the `heightScale` property instead. When `displayMode` is `float`, specifies the maximum height of the component.
+ * @prop --calcite-shell-panel-height: When `layout` is `horizontal`, or `layout` is `vertical` and `displayMode` is `float-content`, specifies the height of the component.


question: should this be when displayMode is float-content or float?

…github.com:Esri/calcite-design-system into josercarcamo/7513-shell-panel-add-float-display-v2

…-to-monorepo * origin/dev: chore: add license to npm package (#9852) build(deps): update dependency @types/eslint to v8.56.11 (#9895) build(deps): update dependency lerna to v8.1.7 (#9896) build(deps): update dependency @floating-ui/dom to v1.6.8 (#9859) build(deps): update dependency chromatic to v11.5.6 (#9837) build(deps): update storybook monorepo to v8.2.6 (#9838) build(deps): update dependency jsdom to v24.1.1 (#9843) build(deps): update dependency @cspell/eslint-plugin to v8.12.1 (#9844) build(deps): update angular-cli monorepo to v18.1.2 (#9874) chore: release next feat(shell-panel): deprecate float displayMode and add float-content and float-all (#9795) chore: release next fix(tooltip): allow focusing on a reference element and then clicking on a tooltip (#9878) chore: release next build(deps): update package-lock (#9884) build(deps): update github-script types (#9886) build(deps): bump node version pinned by volta (#9887) feat(combobox-item): apply heading color according to updated spec (#9883) fix(panel): correct footer padding and layout (#9868) feat(dialog): add padding to default slot (#9871)

…and float-all (#9795) **Related Issue:** #7513 ## Summary Replaced display mode "float" with "float-content" and added "float-all". Deprecated "float".

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-ui-icons: 3.30.0</summary> ## [3.30.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons-v3.29.0...@esri/calcite-ui-icons@3.30.0) (2024-07-31) ### Miscellaneous Chores * Add calcite-ui-icons to monorepo ([#9835](#9835)) ([05264ea](05264ea)) </details> <details><summary>@esri/calcite-components: 2.11.0</summary> ## [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.10.1...@esri/calcite-components@2.11.0) (2024-07-31) ### Features * **chip:** Enhance multi-select group affordance ([#9286](#9286)) ([fd150e1](fd150e1)) * **color-picker, color-picker-hex-input:** Add input auto commit, blur and auto select enhancements. ([#9701](#9701)) ([b2be625](b2be625)) * **combobox-item:** Apply heading color according to updated spec ([#9883](#9883)) ([9f642ff](9f642ff)) * **combobox, combobox-item:** Add `description`, `shortHeading` props and `content-end` slot ([#9771](#9771)) ([78eb555](78eb555)) * **combobox, combobox-item:** Add `metadata` support for filtering ([#9819](#9819)) ([5de7787](5de7787)) * **combobox:** Append custom values to top of dropdown ([#9817](#9817)) ([bd55097](bd55097)) * **dialog:** Add padding to default slot ([#9871](#9871)) ([9d89d1d](9d89d1d)) * **dialog:** Adds new dialog component and deprecates the modal component ([#9751](#9751)) ([0111c23](0111c23)) * **icon:** Type icon names ([#9650](#9650)) ([7513f3a](7513f3a)) * **panel, flow-item:** Add alerts slot ([#9778](#9778)) ([8b9b820](8b9b820)) * **panel, flow-item:** Add beforeClose property ([#9770](#9770)) ([aefd3cb](aefd3cb)) * **panel, flow-item:** Add scale property ([#9730](#9730)) ([27c597e](27c597e)) * Provide info message on stamped version instead of warning ([#9739](#9739)) ([b25cb7b](b25cb7b)) * **shell-panel:** Deprecate float displayMode and add float-content and float-all ([#9795](#9795)) ([bf93728](bf93728)) * **tooltip:** Support touch events ([#9487](#9487)) ([633706b](633706b)) ### Bug Fixes * **block-section:** Apply missing CSS class to start/end icon ([#9688](#9688)) ([2169ed2](2169ed2)) * **block:** Remove top padding when no heading is defined ([#9782](#9782)) ([704f5df](704f5df)) * **carousel:** Prevent duplicate animation when navigating via keyboard ([#9848](#9848)) ([cfdbd44](cfdbd44)) * **combobox-item:** Tweak center content font-weight and spacing ([#9818](#9818)) ([a67c4af](a67c4af)) * **deps:** Move @types/sortablejs as a dependency so the public types resolve properly ([#9786](#9786)) ([3d47c52](3d47c52)) * **dialog:** Fix menu positioning when when overlayPositioning is 'fixed' and menuOpen is true ([#9891](#9891)) ([4390177](4390177)) * Fix issue in Firefox where disabled elements were incorrectly enabled when a sibling was enabled ([#9710](#9710)) ([cd4d52c](cd4d52c)) * **flow-item:** Set closed property to true when internal panel is closed ([#9715](#9715)) ([f7d2a4f](f7d2a4f)) * Improve browser check to resolve SSR errors ([#9897](#9897)) ([bdb225b](bdb225b)) * **input-date-picker:** Ensure initial value is in range ([#9894](#9894)) ([7d05134](7d05134)) * **input-number:** Restore decimal input mode default ([#9741](#9741)) ([1165dca](1165dca)) * **panel, flow-item:** Fix footer-padding CSS prop regression ([#9757](#9757)) ([f935790](f935790)) * **panel, flow-item:** Prevent footer slots from conflicting with each other ([#9856](#9856)) ([cffaff8](cffaff8)) * **panel:** Correct footer padding and layout ([#9868](#9868)) ([1e02ece](1e02ece)) * **radio-button-group:** Remove blank clickable space outside of label ([#9793](#9793)) ([4cc24a0](4cc24a0)) * **segmented-control:** Make check state update correctly ([#9733](#9733)) ([602c922](602c922)) * **shell:** Fix resizing a slotted shell-panel when clicking to resize ([#9846](#9846)) ([326001c](326001c)) * **shell:** Update shell to correctly position calcite shell panel at shell's bottom ([#9748](#9748)) ([5959db7](5959db7)) * **tab-title:** Adjust hover styling for `bordered` Tab Title ([#9867](#9867)) ([a77cd27](a77cd27)) * **tabs:** Handle tab close events that remove the associated tab-title and tab elements from the DOM ([#9768](#9768)) ([bda619c](bda619c)) * **tabs:** Update tab title indicator display ([#9666](#9666)) ([5f0914b](5f0914b)) * **tile:** Center align contentTop and contentBottom slots when alignment prop equals "center" ([#9732](#9732)) ([1a8393b](1a8393b)) * **tile:** Center align slot's text when alignment is equal to center ([#9773](#9773)) ([8611bfc](8611bfc)) * **time-picker:** Render meridiem first for korean locale ([#9842](#9842)) ([897f924](897f924)) * **tooltip:** Allow focusing on a reference element and then clicking on a tooltip ([#9878](#9878)) ([dfca2d4](dfca2d4)) * Widen icon type to allow string ([#9915](#9915)) ([44138b1](44138b1)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from ^3.29.1-next.0 to ^3.30.0 </details> <details><summary>@esri/calcite-components-angular: 2.11.0</summary> ## [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.10.1...@esri/calcite-components-angular@2.11.0) (2024-07-31) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.11.0-next.30 to ^2.11.0 </details> <details><summary>@esri/calcite-components-react: 2.11.0</summary> ## [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.10.1...@esri/calcite-components-react@2.11.0) (2024-07-31) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.11.0-next.30 to ^2.11.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-ui-icons: 3.30.0</summary> [3.30.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons-v3.29.0...@esri/calcite-ui-icons@3.30.0) (2024-07-31) * Add calcite-ui-icons to monorepo ([#9835](#9835)) ([05264ea](05264ea)) </details> <details><summary>@esri/calcite-components: 2.11.0</summary> [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.10.1...@esri/calcite-components@2.11.0) (2024-07-31) * **chip:** Enhance multi-select group affordance ([#9286](#9286)) ([fd150e1](fd150e1)) * **color-picker, color-picker-hex-input:** Add input auto commit, blur and auto select enhancements. ([#9701](#9701)) ([b2be625](b2be625)) * **combobox-item:** Apply heading color according to updated spec ([#9883](#9883)) ([9f642ff](9f642ff)) * **combobox, combobox-item:** Add `description`, `shortHeading` props and `content-end` slot ([#9771](#9771)) ([78eb555](78eb555)) * **combobox, combobox-item:** Add `metadata` support for filtering ([#9819](#9819)) ([5de7787](5de7787)) * **combobox:** Append custom values to top of dropdown ([#9817](#9817)) ([bd55097](bd55097)) * **dialog:** Add padding to default slot ([#9871](#9871)) ([9d89d1d](9d89d1d)) * **dialog:** Adds new dialog component and deprecates the modal component ([#9751](#9751)) ([0111c23](0111c23)) * **icon:** Type icon names ([#9650](#9650)) ([7513f3a](7513f3a)) * **panel, flow-item:** Add alerts slot ([#9778](#9778)) ([8b9b820](8b9b820)) * **panel, flow-item:** Add beforeClose property ([#9770](#9770)) ([aefd3cb](aefd3cb)) * **panel, flow-item:** Add scale property ([#9730](#9730)) ([27c597e](27c597e)) * Provide info message on stamped version instead of warning ([#9739](#9739)) ([b25cb7b](b25cb7b)) * **shell-panel:** Deprecate float displayMode and add float-content and float-all ([#9795](#9795)) ([bf93728](bf93728)) * **tooltip:** Support touch events ([#9487](#9487)) ([633706b](633706b)) * **block-section:** Apply missing CSS class to start/end icon ([#9688](#9688)) ([2169ed2](2169ed2)) * **block:** Remove top padding when no heading is defined ([#9782](#9782)) ([704f5df](704f5df)) * **carousel:** Prevent duplicate animation when navigating via keyboard ([#9848](#9848)) ([cfdbd44](cfdbd44)) * **combobox-item:** Tweak center content font-weight and spacing ([#9818](#9818)) ([a67c4af](a67c4af)) * **deps:** Move @types/sortablejs as a dependency so the public types resolve properly ([#9786](#9786)) ([3d47c52](3d47c52)) * **dialog:** Fix menu positioning when when overlayPositioning is 'fixed' and menuOpen is true ([#9891](#9891)) ([4390177](4390177)) * Fix issue in Firefox where disabled elements were incorrectly enabled when a sibling was enabled ([#9710](#9710)) ([cd4d52c](cd4d52c)) * **flow-item:** Set closed property to true when internal panel is closed ([#9715](#9715)) ([f7d2a4f](f7d2a4f)) * Improve browser check to resolve SSR errors ([#9897](#9897)) ([bdb225b](bdb225b)) * **input-date-picker:** Ensure initial value is in range ([#9894](#9894)) ([7d05134](7d05134)) * **input-number:** Restore decimal input mode default ([#9741](#9741)) ([1165dca](1165dca)) * **panel, flow-item:** Fix footer-padding CSS prop regression ([#9757](#9757)) ([f935790](f935790)) * **panel, flow-item:** Prevent footer slots from conflicting with each other ([#9856](#9856)) ([cffaff8](cffaff8)) * **panel:** Correct footer padding and layout ([#9868](#9868)) ([1e02ece](1e02ece)) * **radio-button-group:** Remove blank clickable space outside of label ([#9793](#9793)) ([4cc24a0](4cc24a0)) * **segmented-control:** Make check state update correctly ([#9733](#9733)) ([602c922](602c922)) * **shell:** Fix resizing a slotted shell-panel when clicking to resize ([#9846](#9846)) ([326001c](326001c)) * **shell:** Update shell to correctly position calcite shell panel at shell's bottom ([#9748](#9748)) ([5959db7](5959db7)) * **tab-title:** Adjust hover styling for `bordered` Tab Title ([#9867](#9867)) ([a77cd27](a77cd27)) * **tabs:** Handle tab close events that remove the associated tab-title and tab elements from the DOM ([#9768](#9768)) ([bda619c](bda619c)) * **tabs:** Update tab title indicator display ([#9666](#9666)) ([5f0914b](5f0914b)) * **tile:** Center align contentTop and contentBottom slots when alignment prop equals "center" ([#9732](#9732)) ([1a8393b](1a8393b)) * **tile:** Center align slot's text when alignment is equal to center ([#9773](#9773)) ([8611bfc](8611bfc)) * **time-picker:** Render meridiem first for korean locale ([#9842](#9842)) ([897f924](897f924)) * **tooltip:** Allow focusing on a reference element and then clicking on a tooltip ([#9878](#9878)) ([dfca2d4](dfca2d4)) * Widen icon type to allow string ([#9915](#9915)) ([44138b1](44138b1)) * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from ^3.29.1-next.0 to ^3.30.0 </details> <details><summary>@esri/calcite-components-angular: 2.11.0</summary> [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.10.1...@esri/calcite-components-angular@2.11.0) (2024-07-31) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.11.0-next.30 to ^2.11.0 </details> <details><summary>@esri/calcite-components-react: 2.11.0</summary> [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.10.1...@esri/calcite-components-react@2.11.0) (2024-07-31) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.11.0-next.30 to ^2.11.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Cherry-pick the release commit from `main`. --- <details><summary>@esri/calcite-ui-icons: 3.30.0</summary> [3.30.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons-v3.29.0...@esri/calcite-ui-icons@3.30.0) (2024-07-31) * Add calcite-ui-icons to monorepo ([#9835](#9835)) ([05264ea](05264ea)) </details> <details><summary>@esri/calcite-components: 2.11.0</summary> [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.10.1...@esri/calcite-components@2.11.0) (2024-07-31) * **chip:** Enhance multi-select group affordance ([#9286](#9286)) ([fd150e1](fd150e1)) * **color-picker, color-picker-hex-input:** Add input auto commit, blur and auto select enhancements. ([#9701](#9701)) ([b2be625](b2be625)) * **combobox-item:** Apply heading color according to updated spec ([#9883](#9883)) ([9f642ff](9f642ff)) * **combobox, combobox-item:** Add `description`, `shortHeading` props and `content-end` slot ([#9771](#9771)) ([78eb555](78eb555)) * **combobox, combobox-item:** Add `metadata` support for filtering ([#9819](#9819)) ([5de7787](5de7787)) * **combobox:** Append custom values to top of dropdown ([#9817](#9817)) ([bd55097](bd55097)) * **dialog:** Add padding to default slot ([#9871](#9871)) ([9d89d1d](9d89d1d)) * **dialog:** Adds new dialog component and deprecates the modal component ([#9751](#9751)) ([0111c23](0111c23)) * **icon:** Type icon names ([#9650](#9650)) ([7513f3a](7513f3a)) * **panel, flow-item:** Add alerts slot ([#9778](#9778)) ([8b9b820](8b9b820)) * **panel, flow-item:** Add beforeClose property ([#9770](#9770)) ([aefd3cb](aefd3cb)) * **panel, flow-item:** Add scale property ([#9730](#9730)) ([27c597e](27c597e)) * Provide info message on stamped version instead of warning ([#9739](#9739)) ([b25cb7b](b25cb7b)) * **shell-panel:** Deprecate float displayMode and add float-content and float-all ([#9795](#9795)) ([bf93728](bf93728)) * **tooltip:** Support touch events ([#9487](#9487)) ([633706b](633706b)) * **block-section:** Apply missing CSS class to start/end icon ([#9688](#9688)) ([2169ed2](2169ed2)) * **block:** Remove top padding when no heading is defined ([#9782](#9782)) ([704f5df](704f5df)) * **carousel:** Prevent duplicate animation when navigating via keyboard ([#9848](#9848)) ([cfdbd44](cfdbd44)) * **combobox-item:** Tweak center content font-weight and spacing ([#9818](#9818)) ([a67c4af](a67c4af)) * **deps:** Move @types/sortablejs as a dependency so the public types resolve properly ([#9786](#9786)) ([3d47c52](3d47c52)) * **dialog:** Fix menu positioning when when overlayPositioning is 'fixed' and menuOpen is true ([#9891](#9891)) ([4390177](4390177)) * Fix issue in Firefox where disabled elements were incorrectly enabled when a sibling was enabled ([#9710](#9710)) ([cd4d52c](cd4d52c)) * **flow-item:** Set closed property to true when internal panel is closed ([#9715](#9715)) ([f7d2a4f](f7d2a4f)) * Improve browser check to resolve SSR errors ([#9897](#9897)) ([bdb225b](bdb225b)) * **input-date-picker:** Ensure initial value is in range ([#9894](#9894)) ([7d05134](7d05134)) * **input-number:** Restore decimal input mode default ([#9741](#9741)) ([1165dca](1165dca)) * **panel, flow-item:** Fix footer-padding CSS prop regression ([#9757](#9757)) ([f935790](f935790)) * **panel, flow-item:** Prevent footer slots from conflicting with each other ([#9856](#9856)) ([cffaff8](cffaff8)) * **panel:** Correct footer padding and layout ([#9868](#9868)) ([1e02ece](1e02ece)) * **radio-button-group:** Remove blank clickable space outside of label ([#9793](#9793)) ([4cc24a0](4cc24a0)) * **segmented-control:** Make check state update correctly ([#9733](#9733)) ([602c922](602c922)) * **shell:** Fix resizing a slotted shell-panel when clicking to resize ([#9846](#9846)) ([326001c](326001c)) * **shell:** Update shell to correctly position calcite shell panel at shell's bottom ([#9748](#9748)) ([5959db7](5959db7)) * **tab-title:** Adjust hover styling for `bordered` Tab Title ([#9867](#9867)) ([a77cd27](a77cd27)) * **tabs:** Handle tab close events that remove the associated tab-title and tab elements from the DOM ([#9768](#9768)) ([bda619c](bda619c)) * **tabs:** Update tab title indicator display ([#9666](#9666)) ([5f0914b](5f0914b)) * **tile:** Center align contentTop and contentBottom slots when alignment prop equals "center" ([#9732](#9732)) ([1a8393b](1a8393b)) * **tile:** Center align slot's text when alignment is equal to center ([#9773](#9773)) ([8611bfc](8611bfc)) * **time-picker:** Render meridiem first for korean locale ([#9842](#9842)) ([897f924](897f924)) * **tooltip:** Allow focusing on a reference element and then clicking on a tooltip ([#9878](#9878)) ([dfca2d4](dfca2d4)) * Widen icon type to allow string ([#9915](#9915)) ([44138b1](44138b1)) * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from ^3.29.1-next.0 to ^3.30.0 </details> <details><summary>@esri/calcite-components-angular: 2.11.0</summary> [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.10.1...@esri/calcite-components-angular@2.11.0) (2024-07-31) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.11.0-next.30 to ^2.11.0 </details> <details><summary>@esri/calcite-components-react: 2.11.0</summary> [2.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.10.1...@esri/calcite-components-react@2.11.0) (2024-07-31) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.11.0-next.30 to ^2.11.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> **Related Issue:** # ## Summary Co-authored-by: Calcite Admin <calcite-admin@esri.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

fix(shell-panel): implement float display mode

725a45e

josercarcamo requested a review from a team as a code owner July 16, 2024 19:50

github-actions bot assigned josercarcamo Jul 16, 2024

github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jul 16, 2024

Merge branch 'dev' into josercarcamo/7513-shell-panel-add-float-displ…

8cef11f

…ay-v2

driskull requested changes Jul 16, 2024

View reviewed changes

josercarcamo added 2 commits July 16, 2024 15:06

Merge branch 'dev' into josercarcamo/7513-shell-panel-add-float-displ…

d881904

…ay-v2

Merge branch 'dev' into josercarcamo/7513-shell-panel-add-float-displ…

a5cb68c

…ay-v2

alisonailea requested changes Jul 17, 2024

View reviewed changes

josercarcamo and others added 20 commits July 19, 2024 14:56

Removed code that reduced action bar size per code review

b9c0b6c

REmoved undefined --calcite-shell-panel-max-width-internal

57c8731

Removed unused line; renamed display-mode values; other

e58b0d5

Made further changes to code

f778931

Merge branch 'dev' into josercarcamo/7513-shell-panel-add-float-displ…

b2698eb

…ay-v2

Reverted name change

38069e2

Merge branch 'dev' into josercarcamo/7513-shell-panel-add-float-displ…

46011d0

…ay-v2

Merge branch 'josercarcamo/7513-shell-panel-add-float-display-v2' of …

6adf1f7

…github.com:Esri/calcite-design-system into josercarcamo/7513-shell-panel-add-float-display-v2

Reverted name change

6c4d128

Merge branch 'dev' into josercarcamo/7513-shell-panel-add-float-displ…

951d1f7

…ay-v2

Separated rules for float-detach and float

e3b608d

Merge branch 'josercarcamo/7513-shell-panel-add-float-display-v2' of …

cbc1c53

…github.com:Esri/calcite-design-system into josercarcamo/7513-shell-panel-add-float-display-v2

Merge branch 'dev' into josercarcamo/7513-shell-panel-add-float-displ…

4329cc9

…ay-v2

Fixing failed test

7722db7

Merge branch 'josercarcamo/7513-shell-panel-add-float-display-v2' of …

3b6755a

…github.com:Esri/calcite-design-system into josercarcamo/7513-shell-panel-add-float-display-v2

Fixing failed test

84b1026

Fixing failed test

957b678

Fixing failed test

50f283f

Moved the '-internal' ending right after 'calcite' for each rule

abf80a5

Merge branch 'dev' into josercarcamo/7513-shell-panel-add-float-displ…

5f39407

…ay-v2

josercarcamo and others added 2 commits July 25, 2024 12:18

Added stories for vertical and horizontal float

46b45f8

Merge branch 'dev' into josercarcamo/7513-shell-panel-add-float-displ…

271b1a5

…ay-v2

josercarcamo added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jul 25, 2024

driskull approved these changes Jul 25, 2024

View reviewed changes

josercarcamo changed the title ~~feat(shell-panel)!: change behavior of 'float' and add 'float-detach'~~ feat(shell-panel)!: change behavior of displayMode 'float' and add 'float-detach' Jul 25, 2024

jcfranco changed the title ~~feat(shell-panel)!: change behavior of displayMode 'float' and add 'float-detach'~~ feat(shell-panel)!: change behavior of displayMode float and add float-detach Jul 25, 2024

Deprecated display mode float and added float-content and float-all

c312514

josercarcamo changed the title ~~feat(shell-panel)!: change behavior of displayMode float and add float-detach~~ feat(shell-panel): deprecate float displayMode and add float-content and float-all Jul 29, 2024

Merge branch 'dev' into josercarcamo/7513-shell-panel-add-float-displ…

c132c44

…ay-v2

josercarcamo removed the breaking change Issues and pull requests with code changes that are not backwards compatible. label Jul 29, 2024

driskull approved these changes Jul 29, 2024

View reviewed changes

josercarcamo added 2 commits July 29, 2024 17:43

Made tests for float and float-content

dd6c2f6

Merge branch 'josercarcamo/7513-shell-panel-add-float-display-v2' of …

141c097

…github.com:Esri/calcite-design-system into josercarcamo/7513-shell-panel-add-float-display-v2

josercarcamo added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jul 30, 2024

josercarcamo merged commit 9beb6eb into dev Jul 30, 2024
12 checks passed

josercarcamo deleted the josercarcamo/7513-shell-panel-add-float-display-v2 branch July 30, 2024 01:25

github-actions bot added this to the 2024-07-30 - Jul Release milestone Jul 30, 2024

calcite-admin mentioned this pull request Jul 30, 2024

chore: release main #9716

Merged

benelan mentioned this pull request Jul 31, 2024

chore: release main (#9716) #9916

Merged

benelan mentioned this pull request Aug 28, 2024

chore: release main #10171

Merged

calcite-admin mentioned this pull request Sep 30, 2024

chore: release main #10457

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(shell-panel): deprecate float displayMode and add float-content and float-all #9795

feat(shell-panel): deprecate float displayMode and add float-content and float-all #9795

josercarcamo commented Jul 16, 2024 •

edited

Loading

driskull left a comment

alisonailea left a comment

alisonailea Jul 17, 2024

josercarcamo Jul 17, 2024

alisonailea Jul 17, 2024

josercarcamo commented Jul 24, 2024

josercarcamo commented Jul 25, 2024

driskull left a comment

josercarcamo commented Jul 29, 2024

driskull left a comment

driskull Jul 29, 2024

driskull Jul 29, 2024

driskull Jul 29, 2024

driskull Jul 29, 2024

feat(shell-panel): deprecate float displayMode and add float-content and float-all #9795

feat(shell-panel): deprecate float displayMode and add float-content and float-all #9795

Conversation

josercarcamo commented Jul 16, 2024 • edited Loading

Summary

driskull left a comment

Choose a reason for hiding this comment

alisonailea left a comment

Choose a reason for hiding this comment

alisonailea Jul 17, 2024

Choose a reason for hiding this comment

josercarcamo Jul 17, 2024

Choose a reason for hiding this comment

alisonailea Jul 17, 2024

Choose a reason for hiding this comment

josercarcamo commented Jul 24, 2024

josercarcamo commented Jul 25, 2024

driskull left a comment

Choose a reason for hiding this comment

josercarcamo commented Jul 29, 2024

driskull left a comment

Choose a reason for hiding this comment

driskull Jul 29, 2024

Choose a reason for hiding this comment

driskull Jul 29, 2024

Choose a reason for hiding this comment

driskull Jul 29, 2024

Choose a reason for hiding this comment

driskull Jul 29, 2024

Choose a reason for hiding this comment

josercarcamo commented Jul 16, 2024 •

edited

Loading