Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add 'start:components' npm script #9942

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

benelan
Copy link
Member

@benelan benelan commented Aug 2, 2024

Related Issue: #9938

Summary

Running npm start from the root of the monorepo will run npm start for all of the packages that have a start script. Therefore, npm start will launch the icon browser in addition to the component demos, now that the @esri/calcite-ui-components lives in the monorepo.

This seems to cause timing issues on Windows where the icons are copied to the components before they are all built.

To only launch the component demos, use npm run start:components.

@benelan benelan requested a review from jcfranco as a code owner August 2, 2024 00:19
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Aug 2, 2024
@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Aug 2, 2024
@benelan benelan merged commit 2b4c939 into dev Aug 2, 2024
12 of 13 checks passed
@benelan benelan deleted the benelan/add-start-components-script branch August 2, 2024 10:22
@github-actions github-actions bot added this to the 2.11.1 patch milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants