fix constructor casts dataset authentication to a POJO

NOTE: no longer cloning definition that is passed in the constructor
Esri · Jan 13, 2021 · 0b032e0 · 0b032e0
1 parent 09c5740
commit 0b032e0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/packages/cedar/CHANGELOG.md b/packages/cedar/CHANGELOG.md
@@ -5,6 +5,9 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+### Fixed
+- fix constructor casts dataset authentication to a POJO
+
 ## [1.1.0]
 
 ### Added

diff --git a/packages/cedar/src/Chart.ts b/packages/cedar/src/Chart.ts
@@ -3,10 +3,6 @@ import { IDataset, ISeries } from './common'
 import { getChartData } from './dataset'
 import { queryDatasets } from './query/query'
 
-function clone(json) {
-  return JSON.parse(JSON.stringify(json))
-}
-
 // TODO: where should these interfaces live?
 
 /**
@@ -114,7 +110,7 @@ export class Chart {
 
     if (definition) {
       // set the definition
-      this.definition(clone(definition))
+      this.definition(definition)
     }
   }