fix constructor casts dataset authentication to a POJO #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: no longer cloning definition that is passed in the constructor
tomwayson
commented
Jan 13, 2021
| @@ -114,7 +110,7 @@ export class Chart { | |||
|
|
|||
| if (definition) { | |||
| // set the definition | |||
| this.definition(clone(definition)) | |||
| this.definition(definition) | |||
There was a problem hiding this comment.
technically this is a breaking change, but since chart.defintion(newDef) didn't clone, I figure we could make it consistent
benstoltz
approved these changes
Jan 13, 2021
|
thanks @benstoltz you remember correctly that we use deepmerge to clone stuff in the render. I'd rather not bring that in here if I can avoid it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: no longer cloning definition that is passed in the constructor