expose option to filter the features in featureLayer that will return a match #136

jgravois · 2016-09-12T23:13:44Z

resolves #135

L.esri.Geocoding.featureLayerProvider({
  label: 'States',
  url: 'http://sampleserver6.arcgisonline.com/arcgis/rest/services/Census/MapServer/3',
  searchFields: ['STATE_NAME'],
  // only return a match if the searched state population exceeds 10 million
  where: 'POP2007 > 10000000'
})

mepdr · 2016-09-20T06:15:55Z

src/Providers/FeatureLayer.js

@@ -95,7 +95,11 @@ export var FeatureLayerProvider = FeatureLayerService.extend({
      queryString.push(field + " LIKE upper('%" + text + "%')");
    }

-    return queryString.join(' OR ');
+    if (this.options.where) {
+      return this.options.where + ' AND ' + queryString.join(' OR ');


Enclose queryString.join(' OR ') in parenthesis otherwise it doesn't work as expected

i'm happy to make the suggested change, but can you clarify exactly what is necessary to generate inappropriate behavior?

everything is working fine on my end.

The issue raises with more than one search field.
The current expression is something like:
IS_ENABLED=1 AND upper(NAME) like ... OR upper(SURNAME) like ...
The one I'd propose is
IS_ENABLED=1 AND (upper(NAME) like ... OR upper(SURNAME) like ... )
The parentheses guarantee the right evaluation order.

thanks for holding my hand through that. my brain wasn't firing on all cylinders yesterday so i only tested w/ two distinct words within the search.

resolved by #144.

expose option to filter which features are searched

3ef3f60

jgravois mentioned this pull request Sep 12, 2016

provider where option #135

Closed

jgravois merged commit 9d57887 into Esri:master Sep 14, 2016

mepdr reviewed Sep 20, 2016

View reviewed changes

jgravois deleted the where branch September 21, 2016 17:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expose option to filter the features in featureLayer that will return a match #136

expose option to filter the features in featureLayer that will return a match #136

jgravois commented Sep 12, 2016

mepdr Sep 20, 2016

jgravois Sep 20, 2016

mepdr Sep 21, 2016

jgravois Sep 21, 2016

expose option to filter the features in featureLayer that will return a match #136

expose option to filter the features in featureLayer that will return a match #136

Conversation

jgravois commented Sep 12, 2016

mepdr Sep 20, 2016

Choose a reason for hiding this comment

jgravois Sep 20, 2016

Choose a reason for hiding this comment

mepdr Sep 21, 2016

Choose a reason for hiding this comment

jgravois Sep 21, 2016

Choose a reason for hiding this comment