Feat: new methods for users to follow and unfollow initiatives #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 56 57 +1
Lines 855 885 +30
Branches 114 117 +3
=====================================
+ Hits 855 885 +30
Continue to review full report at Codecov.
|
|
also resolves #25 |
tomwayson
approved these changes
Mar 15, 2019
packages/initiatives/src/follow.ts
Outdated
|
|
||
| const getTag = (initiativeId: string) => `hubInitiativeId|${initiativeId}`; | ||
|
|
||
| const getUserUrl = (session: UserSession) => |
There was a problem hiding this comment.
maybe this belongs in @esri/arcgis-rest-auth?
There was a problem hiding this comment.
right now, getPortal() and getPortalUrl() can be found in request.
i have a note here to move them to @esri/arcgis-rest-common, so my preference would be to do the same with getUserUrl().
AFFECTS PACKAGES: @esri/hub-initiatives
jgravois
force-pushed
the
feat/follow-initiative
branch
from
c843606 to
aeef22e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/esridc/hub-components/issues/1