Use pending transaction nonce as a default #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: Submitting more than one transaction from the same account before the block is mined resulted with colliding transactions, because of the same nonce. This change takes the nonce from the pending transactions, so it's incrementes as the pool growths before block is mined. Relates to: EthWorks#35
Reason: It allows a developer to calculate transaction nonce on his own. May be needed when you want to control transactions order or calculate nonce using transaction pool rather than relying on current client algorithm. Relates to: - EthWorks#35 - ethereum/go-ethereum#2880
kulerskim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with colliding transactions, additionally allow passing alternate transaction nonce value if needed. Please comment if you see a better solution for sending more than one similar transaction per single mined block.
Relates to: #35