Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing stRandom/randomStatetest649.json test #103

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Fixing stRandom/randomStatetest649.json test #103

merged 4 commits into from
Feb 5, 2024

Conversation

cokicm
Copy link

@cokicm cokicm commented Feb 2, 2024

opCodeCopy instruction tried to allocate memory even when length was zero. Since this specific test used invalid memory offset, allocation failed causing rollback and eventually test failure.

Description

Please provide a detailed description of what was done in this PR

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

…ruction tried to allocate memory even when length was zero. Since this specific test used invalid memory offset, allocation failed causing rollback and eventually test failure.
Stefan-Ethernal
Stefan-Ethernal previously approved these changes Feb 4, 2024
state/runtime/evm/instructions_test.go Outdated Show resolved Hide resolved
goran-ethernal
goran-ethernal previously approved these changes Feb 4, 2024
@cokicm cokicm dismissed stale reviews from goran-ethernal and Stefan-Ethernal via 73abe36 February 4, 2024 20:27
Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
@Stefan-Ethernal Stefan-Ethernal merged commit 43d6315 into Ethernal-Tech:develop Feb 5, 2024
6 of 7 checks passed
@cokicm cokicm deleted the fix-stRandom2 branch February 8, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants