Adding hash check for empty hash when configured #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llidingWithNonEmptyAccount_calls tests by checking validity.
Co-authored-by: Goran Rojovic <100121253+goran-ethernal@users.noreply.github.com>
Stefan-Ethernal
merged commit d520e9c
into
Ethernal-Tech:feat/eip-3607
7 of 9 checks passed
Stefan-Ethernal
added a commit
that referenced
this pull request
Feb 15, 2024
* Adding hash check for empty hash when configured (#108) * Fixing transactionCollidingWithNonEmptyAccount_init and transactionCollidingWithNonEmptyAccount_calls tests by checking validity. * Update state/executor.go Co-authored-by: Goran Rojovic <100121253+goran-ethernal@users.noreply.github.com> --------- Co-authored-by: Goran Rojovic <100121253+goran-ethernal@users.noreply.github.com> Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com> * Configurable EIP3607 check --------- Co-authored-by: cokicm <mita.cokic@gmail.com> Co-authored-by: Goran Rojovic <100121253+goran-ethernal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing transactionCollidingWithNonEmptyAccount_init and transactionCollidingWithNonEmptyAccount_calls tests by checking validity.
Description
When executing transactionCollidingWithNonEmptyAccount_init and transactionCollidingWithNonEmptyAccount_calls account tests, hashes were not validated. This push requests adds hash validation to check for empty object hash and stop transaction application in that case.
Changes include
Checklist
Testing