[BLADE-97] Refactor tx signer #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
@grujicf you need to post the following comment to pass the CLA assistant check:
Also, there are some build errors and merge conflicts on the |
| // RLP(chainId, nonce, gasPrice, gas, to, -, -, -) | ||
| hashPreimage.Set(RLP.NewNull()) | ||
| } else { | ||
|
|
|
|
||
| // Checking whether the transaction is a smart contract deployment | ||
| if tx.To() == nil { | ||
|
|
| accessList := RLP.NewArray() | ||
|
|
||
| if tx.AccessList() != nil { | ||
|
|
|
|
||
| // accessTuple contains (address, storageKeys[]) | ||
| for _, accessTuple := range tx.AccessList() { | ||
|
|
| @@ -87,7 +87,8 @@ func TestLondonSignerSender(t *testing.T) { | |||
| } | |||
|
|
|||
| chainID := tc.chainID.Uint64() | |||
| signer := NewLondonOrBerlinSigner(chainID, true, NewEIP155Signer(chainID, true)) | |||
| //signer := NewLondonOrBerlinSigner(chainID, true, NewEIP155Signer(chainID, true)) | |||
| signer := NewLondonOrBerlinSigner(chainID, true, NewEIP155Signer(chainID)) | |||
There was a problem hiding this comment.
We should remove NewLondonOrBerlinSigner.
Also there are some build errors, because crypto.NewEIP155Signer does not have bool parameter anymore, so please take a look to it.
|
I have read the CLA Document and I hereby sign the CLA |
|
@grujicf you have some merge conflicts on |
Stefan-Ethernal
changed the base branch from
feature/berlin
to
feat/refactor-tx-signers
Stefan-Ethernal
merged commit 2999e85
into
Ethernal-Tech:feat/refactor-tx-signers
3 of 7 checks passed
Stefan-Ethernal
pushed a commit
that referenced
this pull request
Feb 19, 2024
* Refactoring the tx singer logic * Build fix * Fix tests
goran-ethernal
pushed a commit
that referenced
this pull request
Feb 23, 2024
* Refactoring the tx singer logic * Build fix * Fix tests
Stefan-Ethernal
added a commit
that referenced
this pull request
Feb 26, 2024
* [BLADE-97] Refactor tx signer (#113) * Refactoring the tx singer logic * Build fix * Fix tests * Revert go.mod and go.sum * Linter fixes and renames * Fix tests * Fix test * Fix tests * Fix EIP155Signer condition * Fix * Fix * Fix * Fix * Remove calcTxHash * Fix lint * Revert go.mod * Address comments (part 1) * Rebase fix * code reorg * Lint fix * Lint fix * err logging * Remove commented code * ChainID check in tx signer * Lint fix * Fix legacy tests * UTs fix * Fix TestTxPool_RecoverableError * Change error message in the Sender fn * Minor change --------- Co-authored-by: grujicf <61869071+grujicf@users.noreply.github.com> Co-authored-by: grujicf998 <grujicf998@gmail.com> Co-authored-by: Goran Rojovic <goran.rojovic@ethernal.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored tx singer logic. If everything is fine,
calcTxHashfunction should be deleted fromtxsigner.go. Also, files such astxsigner_london_berlin.goand other test files are no longer needed. It is necessary to write new tests.Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing